[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#229273: Please fix this.



At Mon, 14 Jun 2004 17:29:06 +0200,
Thomas Hood wrote:
> On Mon, 2004-06-14 at 16:50, GOTO Masanori wrote:
> > I looked at your script.  It looks fine.  However, I think some parts
> > are needed to modify:
> > 
> >   - DESC="name service cache"
> >   + DESC="name service cache daemon"
> 
> The word 'daemon' is superfluous IMO.  Look at the boot messages for
> other services: there are lots that are implemented in daemons whose
> descriptions don't mention that they are daemons.  I think we should
> standardize on that (i.e., on omitting 'daemon').  The important
> thing is that they describe the service, not that they say how it is
> implemented.
> 
> However this is a minor point and its up to you.

OK... I follow your opinion.

> >   - echo "Usage: /etc/init.d/$NAME {start|stop|restart|force-reload}" >&2
> >   + echo "Usage: /etc/init.d/$NAME {start|stop|restart|reload|force-reload}" >&2
> 
> I removed 'reload' from the usage line intentionally.  My reason for
> doing so was the followup from Jeroen van Wolffelaar in #252284.  He
> wrote:
> 
> > ... reload should not be supported then, and force-reload (defined
> > as 'reload if supported, restart otherwise') should behave as defined.
> > See policy 9.3.2.
> 
> Policy 9.3.2 describes reload as:
> 
> > reload: cause the configuration of the service to be reloaded
> >         without actually stopping and restarting the service
> 
> Since we aren't implementing that behavior I thought that we shouldn't
> advertise the "reload" method.  I left it as a synonym for 'restart'
> and 'force-reload' on the reasoning that some people might already be
> using it.  But on second thought, we can be sure that no one is already
> using "reload" because it has never worked before!  So I now think that
> "reload" should be removed from the initscript entirely.

It makes sense.  I reverted my previous change and commited.  Thanks
for your explanation.

Regards,
-- gotom



Reply to: