[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#193904: glibc: [patch] Re: locales.alias even lines are not considered



Le Tue, May 20, 2003 at 12:36:17PM +0200, Laurent Fousse écrivait:
> With the help of Bill, I've located the bug in intl/localealias.c: the
> code that discards the end of an alias line when it doesn't fit in the
> buffer should not be executed when the line fits in the buffer,
> because it may discards one whole useful line.
> 
> I include a patch in a format suitable for debian/patches.

Hi all,

Some more information about the patch I've sent: the original source
tarball included in the debian package seems to lack this bug, whereas
the patched one used to build the binary packages have it.

As the bug was located in the file intl/localealias.c, the patch that
introduce the bug seems to be "cvs.dpatch". The changelog entry reads:

+2002-11-19  Ulrich Drepper  <drepper@redhat.com>
+
+       * intl/localealias.c (read_alias_file): Use only about 400 bytes
+       of stack space instead of 16k.

and you can see further in the file that a while statement has been
moved, IMHO that caused the bug (just grep for localealias.c in the
file).

So the solution would be to fix the cvs patch in the first place
instead of applying mine afterwards.

I hope my explanations make sense, don't hesitate to ask/correct me.

Regards,

Laurent.

Attachment: pgp_ZusbjZa5N.pgp
Description: PGP signature


Reply to: