Re: mips/mipsel -17?

[Guido Guenther <agx@debian.org>]

On Mon, Apr 28, 2003 at 11:36:07AM -0700, Jeff Bailey wrote:
> I was just looking at the buildd pages for glibc, and I noticed that the
> mips build crashed with strange error messages.  Has anyone looked at
> what's up?  -17 doesn't look like it should have changed enough to cause
> that.
Not the glibc changes broke the built but the binutils changes did. This
fixes it (already applied upstream):

diff -u -r1.10 clone.S
--- sysdeps/unix/sysv/linux/mips/clone.S	12 Mar 2003 01:04:51 -0000	1.10
+++ sysdeps/unix/sysv/linux/mips/clone.S	12 Mar 2003 19:04:39 -0000
@@ -63,7 +63,7 @@
 	syscall
 
 	bnez		a3,error
-	beqz		v0,__thread_start
+	beqz		v0,.Lthread_start
 
 	/* Successful return from the parent */
 	addiu		sp,32
@@ -85,6 +85,7 @@
    debug info.  */
 
 ENTRY(__thread_start)
+.Lthread_start:
 	/* cp is already loaded.  */
 	.cprestore	16
 	/* The stackframe has been created on entry of clone().  */

Regards,
 -- Guido