[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#218482: linux-kernel-headers: Some headers seem to expand inline twice



Daniel Jacobowitz <dan@debian.org> writes:

> On Fri, Oct 31, 2003 at 04:45:11PM +0000, Bruce Stephens wrote:

[...]

> Yes, though it should be:
>
>> 
>> #include <iostream>
>> extern "C"
>> {
>> #include <signal.h>
>> }
>
> #include <iostream>
> #inclde <csignal>

OK, my mistake.

[...]

> I don't know if the parse error is a C++ bug or not.  However, the
> __attribute__ should not be used in user-space anyway.  I'll fix
> linux-kernel-headers.

Good.  Apart from anything else, the error message is unenlightening.

[...]

> Well, __attribute__ isn't exactly a decl-specifier.  It's a GCC/G++
> extension and it gets parsed however g++ happens to feel like it
> that day.

Sure, I was referring to the use of inline, not whatever headers
happened to expand it to.

> Oh, and I think "double typedef" is actually legal:
>   double typedef bd_type;

Yuck.  Having said that, that usage might be more readable.  Hmm, I
might convert to using that.

I was worried it might appear all over our code, but it seems to be
limited to a couple of related files, so it was probably one developer
who had poor taste for some reason one day.  I think I'll change them
for stylistic reasons---I prefer "inline <type>".




Reply to: