Bug#183449: locale-gen ignores errors from localedef

[GOTO Masanori <gotom@debian.or.jp>]

At Tue, 04 Mar 2003 23:47:39 +0000,
pmaydell@chiark.greenend.org.uk wrote:
> 
> Package: locales
> Version: 2.2.5-11.2
> 
> I was trying to generate a new locale, and this happened:
> 
> kuzuth:/home/pm215# dpkg-reconfigure locales
> Generating locales...
>   en_GB.UTF-8.../usr/sbin/locale-gen: line 22:  4589 Killed                  localedef -i $input -c -f $charset $locale
>  done
> Generation complete.
> kuzuth:/home/pm215# echo $?
> 0
> 
> 
> (The process was killed by the VM's OOM killer, as it happens.)
> 
> The bug is that locale-gen is ignoring the error return from 
> localedef and exiting with a success code. It should probably be using
> "set -e" or something similar. 
> 
> Also, I'm sure it shouldn't need all those "; \" at the end of each line!

I added "set -e".

> I suspect shell script was not the author's native language...

I'm not author of locale-gen, but I'm tcsh enthusiast, so for me, it's
correct B-)

Regards,
-- gotom