[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#173082: libnss-db's libc-lock.h



On Mon, Feb 10, 2003 at 10:18:21AM -0500, Ben Collins wrote:
> > #if __LT_SPINLOCK_INIT == 0
> > #  define __libc_lock_define_initialized(CLASS,NAME) \
> >   CLASS pthread_mutex_t NAME;
> > #else
> > #  define __libc_lock_define_initialized(CLASS,NAME) \
> >   CLASS pthread_mutex_t NAME = PTHREAD_MUTEX_INITIALIZER;
> > #endif
> > 
> > On hppa, __LT_SPINLOCK_INIT is defined as:
> > #define __LT_SPINLOCK_INIT ((__atomic_lock_t){ 1 })
> > 
> > So, either the libc pthreads patch needs to change, or the libc-lock.h header
> > needs to be updated to work with hppa's value of __LT_SPINLOCK_INIT ...
>  
> The latter I would guess.

Glibc defines __LT_SPINLOCK_INIT on HPPA as "1".  Another constant hods
the initializer; __LT_SPINLOCK_INIT is a predicate.

Carlos has since changed that in his HPPA patches for linuxthreads,
which haven't been accepted upstream, because they didn't like how he
was doing it, I think.

All libnss-db needs to do is remove the first half of the #if.  This
isn't a bug in glibc, since that's a private copy of libc-lock.h.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



Reply to: