Re: cvs commit to glibc-package by jbailey
On Wed, Oct 16, 2002 at 09:11:01PM +0900, GOTO Masanori wrote:
> At Wed, 16 Oct 2002 07:37:56 -0400,
> Ben Collins wrote:
> > > - debian/rules: Fail build on failed 'make check'.
> >
> > Come on. Didn't we talk about this?
>
> Hm, this change is below issue, removing -k.
> It causes some architecture cannot build.
> IMHO, this change is not appropriate for such archs...
Yeah. Removing -k is the worst part. Without the -k, the "make check"
stops on the first failure, so you never see all the failures.
The initial '-' should have been the only thing removed to make the
build fail on "make check" errors. Even that is wrong, as I have
explained in the past. It's a superfluous. If any of the porters are
building unstable glibc and uploading it without checking the results of
"make check", they are asking for trouble anyway.
Please revert this.
> - -$(MAKE) -k SHELL=/bin/bash -C $(objdir) check 2>&1 | tee -a $(log_test)
> + $(MAKE) SHELL=/bin/bash -C $(objdir) check 2>&1 | tee -a $(log_test)
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo - http://www.deqo.com/
Reply to: