Re: catgets 'make check' failure
On Tue, Oct 01, 2002 at 07:30:41PM -0400, Ben Collins wrote:
> > > annexc is an expected failure. Check the output sometime.
> > I have, but I haven't looked at what the test is supposed to do
> > yet. =)
> > I want to either fix the test or patch it so it doesn't run.
> Don't keep it from running. Leave it. It's been there for years and
> hurts nothing. There's no reason to get rid of it now.
One of my goals is to remove the '-k' from the make check line. I
want the build to fail if there are bad tests - that way regressions
are caught and dealt with very quickly on arch's that the glibc
maintainers aren't using.
> Just read the output, you'll see what it is for. Basically it checks
> certain headers to see if they define macros that they should and
> also don't define macros that they shouldn't.
> Do not remove the test.
You haven't explained why not. A test that fails and is ignored is
useless and misleading.
--
learning from failures is nice in theory...
but in practice, it sucks :)
- Wolfgang Jaehrling
Reply to: