Re: Make: Obscure bug with wildcards
>>>>> Joel Klecker writes:
Joel> At 16:33 +0100 2000-02-06, Andreas Jaeger wrote:
>> Could you try the appended patch for make? make doesn't properly
>> initialize d_type - and this might be the problem (I noticed a similar
>> problem with wildcards in glibc which was fixed with this patch from
>> Andreas Schwab).
>>
>> Andreas
>>
>> --- dir.c
>> +++ dir.c 2000/01/20 15:40:41
>> @@ -1044,6 +1044,9 @@
>> #ifdef _DIRENT_HAVE_D_NAMLEN
d-> d_namlen = len - 1;
>> #endif
>> +#ifdef _DIRENT_HAVE_D_TYPE
>> + d->d_type = DT_UNKNOWN;
>> +#endif
>> memcpy (d->d_name, df->name, len);
>> return d;
>> }
Joel> This patch seems to work. I've also discovered that backing out the last
Joel> change to sysdeps/generic/glob.c in glibc works (not that I advocate that
Joel> as a solution).
That change to glob.c revealed the bug in make.
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.rhein-neckar.de
Reply to: