[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fwd: Bug#958047: RFS: mercantile/1.0-1 [ITP] -- python3-mercantile - Web mercator XYZ tile utilities



Hi,

you to fast for me ;-)

> > The extended description for the mercantile package is the same as for
> > python3-mercantile. Add a paragraph explaining what the package
> > 
> > contains, see:
> >  https://salsa.debian.org/debian-gis-team/python-stetl/-/blob/master/debia
> >  n/control
> This still needs to be fixed.

Done

> 
> >>> debian/copyright:
> Because the license and copyright holder are the same, the * and docs/*
> sections should be merged.
> 
> >>> debian/patches/0001-removed-coveralls-from-test-requirements.patch
> 
> This is mostly good now, an empty line between the headers and body
> improves readability.
> 
> You also need to configure your quiltc and refresh the patch:
> 
>  https://debian-gis-team.pages.debian.net/policy/policy.html#quilt

Done

> >>> debian/rules:
> Instead of changing directory use `make -C docs clean` like the build
> target.
> 
> Instead of using `rm -f` use $(RM) which expands to `rm -f`.

Done and the Lines are needed. Otherwise it does not build twice.

> 
> An empty line between dh_auto_<foo> and the custom commands improves
> readability.
>
Done

> Removing the two dot directories is probably not required. Have you
> tried building the package twice in a row?
> 
>  gbp buildpackage --git-pbuilder --git-pbuilder-options="--twice"
> 
> >>> debian/watch:
> To make it more robust the patten for the tag needs to include
> alternatives when the 'v' prefix is not used. See:
> 
>  https://salsa.debian.org/debian-gis-team/fiona/-/blob/master/debian/watch

Done

> Kind Regards,
> 
> Bas

Regards,

Joachim



Reply to: