[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fwd: Bug#958047: RFS: mercantile/1.0-1 [ITP] -- python3-mercantile - Web mercator XYZ tile utilities

On 5/3/20 11:39 AM, Joachim Langenbach wrote:
> Hello Bas,
> many thanks for your fast, detailed review. It is very appriecated, also I 
> haven't found the time to fix all issues until now. But now I have uploaded a 
> the version 1.1.4-1 to mentors.

Please push your changes to the repo on Salsa, you may need to update
the origin remote to use the repo under the debian-gis-team namespace:

 git remote set-url origin \
 git remote set-url --push origin \

>> debian/control:
>>  Restructure the file with `cme` as documented in the policy:
>>   https://debian-gis-team.pages.debian.net/policy/policy.html#cme
> cme fix does not change a thing. Do I miss something? 

The command is:

 cme fix dpkg-control

>> debian/copyright:
>>  While `licensecheck --deb-machine -r *` doesn't report the copyright
>>  years, LICENSE.txt does and those are missing for Sean Gillies.
>>  The usual syntax for the Copyright field is:
>>   Copyright: <year-year>, <author>
>>                   <year>, <other author>
>>  Notice the comma between the copyright years and copyright holder.
>>  The copyright documented docs/conf.py is also missing.
> May you explain this a little bit? I didn't understand that.

 $ grep Copyright LICENSE.txt
 Copyright (c) 2014-2017, Sean C. Gillies

 $ grep ^copyright docs/conf.py
 copyright = "2017, Sean C. Gillies"

debian/copyright only has:

 Copyright: Sean Gillies <sean@mapbox.com>

Note the lack of copyright years.

>> debian/watch:
>>  Handle common issues by adding dversionmangle & uversionmangle:
>>    https://wiki.debian.org/debian/watch#Common_mistakes
>>  See for example:
>>   https://salsa.debian.org/debian-gis-team/fiona/-/blob/master/debian/watch
> Done. By the way: The fiona team is using upstream releases instead of tags as 
> I do. If I'm thinking about it, I may should switch to releases to. Is there a 
> common understanding about that? Or depends it on the behaviour of the 
> upstream team?

The /tags endpoint was broken at some point, at that time /releases was
still working for uscan hence most packages use /releases instead of /tags.

The /releases endpoint also allows to upload artifacts, like release
tarballs in addition to the automatically generated tarballs from the
git repo. You may need to exclude those by explicitly checking for
/archive in the URL. The mapnik release tarballs are not what we want
for example.

Kind Regards,


 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Reply to: