[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Reducing lintian messages on mod_tile

Hi Sebastiaan,

Thank you for the review , and sorry for the poor quality of work.

I will try to learn how to make patches better, and hopefully will try again in the future.

On Tue, Jul 16, 2019 at 8:52 PM Sebastiaan Couwenberg <sebastic@xs4all.nl> wrote:
Hi Boris,

Thanks for your work on mod_tile.

Your patches cannot be applies as it, because they combine changes to
files in the debian directory and upstream files. Changes to upstream
files must be done with quilt patches [0].

Your first patch for example adds libjs-openlayers to Suggests (which
should be Depends) in debian/control but also modifies slippymap.html in
the upstream sources. The latter change should be a quilt patch. When
you commit both the changes to debian/patches and debian/control, that
can be exported as a single patch we can apply.

If you have created a guest account on Salsa you can create a merge
request for your change,s which you can then refine based on the review
feedback. We can also do that over email.

I don't have time go over your patches in detail right now, otherwise I
would have just fixed the issues, so it's up to you which method your
prefer to improve your patches so that they can be included in repo on

[0] https://debian-gis-team.pages.debian.net/policy/policy.html#patches

Kind Regards,


 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Reply to: