[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: opencpn: Unbundling wxcurl or not: re-evaluation of the situation.



On 9/30/18 8:21 PM, Sebastiaan Couwenberg wrote:
> On 9/30/18 8:14 PM, Alec Leamas wrote:
>> I have made a more detailed look into the wxcurl code in opencpn and a
>> tentative wxcurl package (draft in salsa). Facts in short:
>>
>>   - Upstream is abandoned since 2010.
>>   - Upstream uses the bakefiles system to generate Makefile.in +
>> configure. bakefiles is not available in debian  (I have used fedora to
>> update Makefile.in + configure).
>>   - OpenCPN has made a large number of non-controversial patches:
>> bugfixes, expanded API etc.
>>   - OpenCPN has also made a major API change to fix a problem in the
>> Windows build.
>>   - An OpenCPN package will need a wxcurl package with the same API
>> change or carry patches for an unrevised API. The latter is feasible,
>> but hard to upstream and perhaps a pain to maintain.
>>
>> Bottom line: I'm not that convinced that unbundling wxcurl is the proper
>> way to go any more, mostly due to the combination of an abandoned
>> upstream and a revised API.
>>
>> The alternative would be to use the wxcurl code bundled in OpenCPN.
>>
>> Thoughts?
> 
> Based on the invasive changes made in the OpenCPN fork, keeping the
> embedded copy makes sense.
> 
> The issues with the wxcurl package should be documented in its source
> package for future reference.

And also note this motivation in the ITP (#907071) when closing the
bugreport.

Kind Regards,

Bas


Reply to: