On Thu, 2005-11-24 at 05:29 +0200, alex bodnaru wrote: > i am finally quite content with my openev packages, and i wish you to > tell me what you think. I'm not sure where to download your orig.tar.gz from, so I can't build the package and check it or run lintian and linda over it. It is usually best to upload packages to mentors.debian.net. Stuff I noticed from the diff.gz and suggestions: Don't include CVS dirs in the orig.tar.gz (use cvs export). Ask upstream to make a release. debian/README.Debian: The first sentence should be removed. The rest should be stripped out and replaced with the standard information about download location in debian/copyright (list the cvs repository instead of web location). debian/changelog: You might want to make the version 0.0.0+CVS20051112-1 instead, so you don't have to add an epoch when upstream makes a real release with a version number. debian/openev.menu: I'd suggest putting it in the Apps/Science part of the menu (instead of just Apps). debian/openev-doc.doc-base: Needs a proper Title, Author, Abstract and Section (use Apps/Science). debian/copyright: You forgot to add upstream's copyright notices and licencing information. http://lists.debian.org/debian-legal/2003/12/msg00194.html http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html The download location should point at the CVS server. Include copyright, licence and download information about the wmsclient and other stuff you added to the source package. debian/control: findutils is Essential: yes, so you don't have to build-depend on it. in the openev-doc long description, you might want to mention that the package contains documentation. debian/rules: Strip out dh_make cruft comments at the start? the ./configure line ignores CFLAGS set above that line Remove lines that you don't need (such as the commented out dh_* commands) debian/watch.ex: Either delete, or rename to debian/watch and fix it. Rest of the diff: Why do you remove and add blank lines to the source (gvshapeslayer.c)? You might want to split all your changes up into separate sets of patches using dpatch or quilt. what is the difference between the pygtk and gtk modules in python? I'm curious about the version.config file that you added, I suggest to just use 0.0.0 if upstream has no version, otherwise use the following version in debian/changelog: 1.8.0+CVS20051112-1. Please send your other changes to the *.c and *.py files to upstream. -- bye, pabs http://pabs.zip.to
Attachment:
signature.asc
Description: This is a digitally signed message part