[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107416: marked as done (gcc-14: Please build with -fno-fold-mem-offsets on m68k)

Your message dated Mon, 09 Jun 2025 09:19:04 +0000
with message-id <E1uOYem-009KGw-PT@fasolo.debian.org>
and subject line Bug#1107416: fixed in gcc-14 14.3.0-2
has caused the Debian Bug report #1107416,
regarding gcc-14: Please build with -fno-fold-mem-offsets on m68k
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107416: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107416
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: gcc-14
Version: 14.2.0-19
Severity: normal
Tags: patch
User: debian-68k@lists.debian.org
Usertags: m68k
X-Debbugs-Cc: debian-68k@lists.debian.org

Hello,

the new RTL optimization introduced in [1] breaks the gcc-14 build on m68k.

As discovered by the Gentoo m68k maintainers, building gcc-14 with the option
-fno-fold-mem-offsets to disable this new optimization fixes this problem.

The option does not seem to be needed on gcc-15 which builds fine in experimental [2].

I have used the following patch against the gcc-14 package to pass the option
during build which works for me:

--- debian/rules2.orig	 2025-02-19 16:04:38.000000000 +0100
+++ debian/rules2	 2025-06-06 11:55:20.606692824 +0200
@@ -227,6 +227,17 @@
   endif
 endif
 
+ifeq ($(DEB_TARGET_ARCH),m68k)
+  CFLAGS               += -fno-fold-mem-offsets
+  CXXFLAGS             += -fno-fold-mem-offsets
+  CFLAGS_FOR_BUILD     += -fno-fold-mem-offsets
+  CXXFLAGS_FOR_BUILD   += -fno-fold-mem-offsets
+  CFLAGS_FOR_TARGET    += -fno-fold-mem-offsets
+  CXXFLAGS_FOR_TARGET  += -fno-fold-mem-offsets
+  BOOT_CFLAGS          += -fno-fold-mem-offsets
+  STAGE1_CFLAGS        += -fno-fold-mem-offsets
+endif
+
 ifneq (,$(findstring -fno-omit-frame-pointer,$(shell DEB_HOST_ARCH=$(DEB_TARGET_ARCH) dpkg-buildflags --get CFLAGS)))
   CFLAGS_FRAME_POINTER = -fno-omit-frame-pointer
 else

The gcc maintainer will certainly know better whether all of these are
needed to fix the build and consequently avoid other packages from being
miscompiled or failing to build.

Thanks,
Adrian

> [1] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=04c9cf5c786b94fbe3f6f21f06cae73a7575ff7a
> [2] https://buildd.debian.org/status/package.php?p=gcc-15&suite=experimental

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- debian/rules2.orig   2025-02-19 16:04:38.000000000 +0100
+++ debian/rules2        2025-06-06 11:55:20.606692824 +0200
@@ -227,6 +227,17 @@
   endif
 endif

+ifeq ($(DEB_TARGET_ARCH),m68k)
+  CFLAGS               += -fno-fold-mem-offsets
+  CXXFLAGS             += -fno-fold-mem-offsets
+  CFLAGS_FOR_BUILD     += -fno-fold-mem-offsets
+  CXXFLAGS_FOR_BUILD   += -fno-fold-mem-offsets
+  CFLAGS_FOR_TARGET    += -fno-fold-mem-offsets
+  CXXFLAGS_FOR_TARGET  += -fno-fold-mem-offsets
+  BOOT_CFLAGS          += -fno-fold-mem-offsets
+  STAGE1_CFLAGS        += -fno-fold-mem-offsets
+endif
+
 ifneq (,$(findstring -fno-omit-frame-pointer,$(shell DEB_HOST_ARCH=$(DEB_TARGET_ARCH) dpkg-buildflags --get CFLAGS)))
   CFLAGS_FRAME_POINTER = -fno-omit-frame-pointer
 else

--- End Message ---
--- Begin Message --- 
Source: gcc-14
Source-Version: 14.3.0-2
Done: Matthias Klose <doko@debian.org>

We believe that the bug you reported is fixed in the latest version of
gcc-14, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1107416@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthias Klose <doko@debian.org> (supplier of updated gcc-14 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 09 Jun 2025 10:59:15 +0200
Source: gcc-14
Architecture: source
Version: 14.3.0-2
Distribution: experimental
Urgency: medium
Maintainer: Debian GCC Maintainers <debian-gcc@lists.debian.org>
Changed-By: Matthias Klose <doko@debian.org>
Closes: 1107416
Changes:
 gcc-14 (14.3.0-2) experimental; urgency=medium
 .
   * Update to git 20250609 from the gcc-14 branch.
     - Fix PR target/119834 (S390), PR middle-end/118819,
       PR rtl-optimization/117239, PR rtl-optimization/117239,
       PR tree-optimization/117358, PR target/86772 (microblaze),
       PR c++/120123, PR c++/120161, PR fortran/85750, PR fortran/98454,
       PR target/120441 (AVR).
   * Don't default to -fno-fold-mem-offsets on m68k (Adrian Glaubitz).
     Closes: #1107416.
Checksums-Sha1:
 2a41058fca19908f697081f253c04092abffc34f 42270 gcc-14_14.3.0-2.dsc
 2d5561a2970bd7fdd49211e036172e41be4da898 580152 gcc-14_14.3.0-2.debian.tar.xz
 6fecdf711ebf83911ff8c9ee57c7bb2b6818d94b 9868 gcc-14_14.3.0-2_source.buildinfo
Checksums-Sha256:
 cbc11d4676b4845a4df101bebb97764441a6e15798b8b0f495c59c7fc9c01e59 42270 gcc-14_14.3.0-2.dsc
 5dc2badaa7f469d678b3842cb698514716fa962d546271c569b8d9bcd71e3541 580152 gcc-14_14.3.0-2.debian.tar.xz
 d895689f7199a87c230b281ca2d341f51eb25f19e654221e3985841e716130fe 9868 gcc-14_14.3.0-2_source.buildinfo
Files:
 5b319ac695b2f4953e527c09f9f5c7bf 42270 devel optional gcc-14_14.3.0-2.dsc
 18f78178a8e517b835dbdc451d0b395d 580152 devel optional gcc-14_14.3.0-2.debian.tar.xz
 ab5f411364cb1480c03f32718dcd154a 9868 devel optional gcc-14_14.3.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE1WVxuIqLuvFAv2PWvX6qYHePpvUFAmhGowsQHGRva29AZGVi
aWFuLm9yZwAKCRC9fqpgd4+m9cdXEACSqvnB/bWXQIoyPh3m2R3CO/uDsDCeYWI0
eejuAeaKXUULODDfmyy8bTNMA+903fyri0js5ii9ZSUSgT2c2IldDKtIYDSO8D+b
xPnIalbEt1djDpj28yje6ChvaRfT5sQysuaF78qn85xYlzw5rvRoXVbWDGgMEBIr
4IQ+JcswynaGbDdlFOq03aNDCwFjBwVM+VeBCof+KBUEuW5/QP1zn1j4CgF00VJU
j9KvMCN8CoiV+T1JK8JoQ4HWrHSCWDyv82k/McCs1dduk3bqUkZ3O83mNI1Y47yF
/drramOhDh7GNbvTpw1uifLoMU1wbP0GjbZhxyAQaAm9R9vggAztuq831N2np6XU
qkFmHp1pL8kw4lNWchZb2U/uJa5LRfdVfBkhBmc42PWn7WaqQ4YyS2oHo9rxu7h2
cbB9tRj8S+hFgZwoMWHR+eJqPey+4y91ZtFmfi3mnfg+0KlL2XCAR4m1lQertHxI
WL7U3KVeppl164F0L4eMEsFzMYWXyD4kx7NrYpY3ROSs8yqxEj2+Ms1DE3kDONr8
VA/ZjCziQQ3roT1e8RvlWR7jN59w+lPX/T+gj0dZYrRwZzzXD2AeuOFxCCAOYVt5
HJw4kSGFQlB5xcEr9H3sKLjBBEmLeY15diYEb3vikL1OosepXT0ixCFiArkHfNzL
SVN1A8YGlw==
=Nx8q
-----END PGP SIGNATURE-----

Attachment: pgpj9KdWWVeRK.pgp
Description: PGP signature


--- End Message ---
Reply to: