[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946792: Acknowledgement (gcc-9: Buffer overflow bug introduced by gcc-search-prefixed-as-ld.diff)



YunQiang Su <wzssyqa@gmail.com> 于2019年12月26日周四 下午2:42写道:
>
> On Tue, 17 Dec 2019 13:08:37 +0100 John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de> wrote:
> > Control: tags -1 +patch
> >
> > Attaching debdiff which incorporates the changes :).
>
> strlen (DEFAULT_REAL_TARGET_MACHINE) + 2
> is not enough here.
>
> In fact in some cases, DEFAULT_REAL_TARGET_MACHINE may have even less space than
>    multiarch_suffix
> for example:
>    mipsel-linux-gnu-9 -mabi=64
> DEFAULT_REAL_TARGET_MACHINE is mipsel-linux-gnu/9/
> while multiarch_suffix is
>    mips64el-linux-gnuabi64

sorry, typo:
  DEFAULT_REAL_TARGET_MACHINE is mipsel-linux-gnu
multiarch_suffix :
  mips64el-linux-gnuabi64/9/

anyway, space may not be enough.

> In fact we need:
>   MAX (strlen(DEFAULT_REAL_TARGET_MACHINE), multiarch_len) + 2
>
> >
> > Adrian
> >
> > --
> >  .''`.  John Paul Adrian Glaubitz
> > : :' :  Debian Developer - glaubitz@debian.org
> > `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
> >   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



-- 
YunQiang Su


Reply to: