Bug#904289: libgo build failure with GCC trunk 20181004
On Mon, Oct 8, 2018 at 8:59 PM, Matthias Klose <doko@debian.org> wrote:
> On 08.10.2018 11:47, Svante Signell wrote:
>> On Fri, 2018-10-05 at 21:10 +0200, Svante Signell wrote:
>>> On Fri, 2018-10-05 at 01:38 +0200, Matthias Klose wrote:
>>>> Hi Svante,
>>>>
>>>> please have a look at the recent libgo build failure with GCC trunk
>>>> 20181004 after the libgo merge. Please could you update the
>>>> patches and send them upstream again?
>>>
>>> Well I don't really know where to submit the patches to upstream, but
>>> here they are. Cc:ing the gcc-snapshot bug 904289@bugs.debian.org
>>> too.
>>
>> Hi again,
>>
>> Seems like more changes were needed this time: Attached are three
>> updated patches:
>> src_libgo_go_syscall.diff
>> add-gnu-to-libgo-headers.diff
>> add-gnu-to-libgo-test-headers.diff
>
> Thanks for the update, but please could you send *all* the patches to
> gcc-patches@gcc.gnu.org, and maybe CC Ian? Patches really have to be ready to
> be applied upstream, and not to some Debian package.
>
> Please see https://gcc.gnu.org/contribute.html how to contribute. libgo might
> be a bit different, because the source is maintained in golang, and then
> imported into GCC.
The absolute best way to contribute to the libgo and gcc/go/gofrontend
directories is to use Gerrit, following the process described at
https://golang.org/doc/contribute.html.
But sending patches to gcc-patches@gcc.gnu.org and CC'ing me is also
OK. Yes, in general the patches have to apply to GCC trunk.
Thanks.
Ian
Reply to: