Bug#755295: Hurd term server (was: Hurd GCC ping)
- To: Thomas Schwinge <thomas@codesourcery.com>
- Cc: 755295@bugs.debian.org, bug-hurd@gnu.org, Roland McGrath <roland@hack.frob.com>, Matthias Klose <doko@ubuntu.com>, Thomas Bushnell <tb@becket.net>, marcus.brinkmann@ruhr-uni-bochum.de, Miles Bader <miles@gnu.org>
- Subject: Bug#755295: Hurd term server (was: Hurd GCC ping)
- From: Samuel Thibault <samuel.thibault@gnu.org>
- Date: Sun, 18 Jan 2015 20:38:29 +0100
- Message-id: <[🔎] 20150118193829.GJ2957@type.youpi.perso.aquilenet.fr>
- Mail-followup-to: Thomas Schwinge <thomas@codesourcery.com>, 755295@bugs.debian.org, bug-hurd@gnu.org, Roland McGrath <roland@hack.frob.com>, Matthias Klose <doko@ubuntu.com>, Thomas Bushnell <tb@becket.net>, marcus.brinkmann@ruhr-uni-bochum.de, Miles Bader <miles@gnu.org>
- Reply-to: Samuel Thibault <samuel.thibault@gnu.org>, 755295@bugs.debian.org
- In-reply-to: <[🔎] 87twzoxd3b.fsf@kepler.schwinge.homeip.net>
- References: <53CAA84C.6080301@debian.org> <53EDFDC1.9050205@ubuntu.com> <87vbpogj0r.fsf@schwinge.name> <87iojtpi1s.fsf@kepler.schwinge.homeip.net> <20141102171311.GS2991@type.youpi.perso.aquilenet.fr> <[🔎] 87twzoxd3b.fsf@kepler.schwinge.homeip.net>
Thomas Schwinge, le Sun 18 Jan 2015 17:34:00 +0100, a écrit :
> (Can you now reproduce the issue?)
Yes.
> Any comments on that already? (I don't feel like
> committing such a change without understanding it.)
>
> --- term/ptyio.c
> +++ term/ptyio.c
> @@ -331,7 +331,7 @@ pty_io_read (struct trivfs_protid *cred,
> }
> }
>
> - if (!(termflags & TTY_OPEN) && !qsize (outputq))
> + if (!(termflags & TTY_OPEN) && packet_mode)
> {
> pthread_mutex_unlock (&global_lock);
> return EIO;
I don't see why it should be done in packet mode only. The qsize check,
on the other hand, makes sense to me, we should keep it.
Samuel
Reply to: