[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#740286: marked as done (gnat-4.9: s-osinte-posix.adb is wrong about timespec.tv_nsec compared to gnat-4.8)



Your message dated Mon, 24 Mar 2014 23:19:10 +0000
with message-id <E1WSE98-0005WX-CG@franck.debian.org>
and subject line Bug#740286: fixed in gnat-4.9 4.9-20140322-1
has caused the Debian Bug report #740286,
regarding gnat-4.9: s-osinte-posix.adb is wrong about timespec.tv_nsec compared to gnat-4.8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
740286: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740286
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: gnat-4.9
Version: 4.9-20140218-2
Severity: important
Tags: patch experimental upstream
User: debian-hurd@lists.debian.org
Usertags: hurd kfreebsd

Hi,

I'm not so sure there is a need to move from s-osinte-posix.adb to the
patched version s-osinte-kfreebsd-gnu.adb for kfreebsd. I see the same
build problem as before when building gnat-4.9 on GNU/Hurd. I think the
change from gnat-4.8 to gnat-4.9 in s-osinte-posix.adb is wrong
(edited):

--- gnat-4.8/gnat-4.8-4.8.2-5/src/gcc/ada/s-osinte-posix.adb
2011-08-01 17:05:02.000000000 +0200
+++ gnat-4.9/gnat-4.9-4.9-20140218/src/gcc/ada/s-osinte-posix.adb
2013-11-16 20:23:13.000000000 +0100

return timespec'(tv_sec => S,
-  tv_nsec => long (Long_Long_Integer (F * 10#1#E9)));
+  tv_nsec => time_t (Long_Long_Integer (F * 10#1#E9)));
end To_Timespec;

 end System.OS_Interface;

According to Posix the tv_nsec should be long:
http://pubs.opengroup.org/onlinepubs/009695299/basedefs/time.h.html

The <time.h> header shall declare the structure timespec, which has at
least the following members:

time_t  tv_sec    Seconds. 
long    tv_nsec   Nanoseconds. 

Linux/kFreeBSD/Hurd all defines struct timespec in time.h as follows:
/* POSIX.1b structure for a time value.  This is like a `struct timeval'
but
   has nanoseconds instead of microseconds.  */
struct timespec
  {
    __time_t tv_sec;            /* Seconds.  */
    __syscall_slong_t tv_nsec;  /* Nanoseconds.  */
  };

--- End Message ---
--- Begin Message ---
Source: gnat-4.9
Source-Version: 4.9-20140322-1

We believe that the bug you reported is fixed in the latest version of
gnat-4.9, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 740286@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ludovic Brenta <lbrenta@debian.org> (supplier of updated gnat-4.9 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 24 Mar 2014 23:02:00 +0100
Source: gnat-4.9
Binary: gnat-4.9-base gnat-4.9 gnat-4.9-sjlj libgnat-4.9 libgnat-4.9-dbg libgnatvsn4.9-dev libgnatvsn4.9 libgnatvsn4.9-dbg libgnatprj4.9-dev libgnatprj4.9 libgnatprj4.9-dbg
Architecture: source all amd64
Version: 4.9-20140322-1
Distribution: experimental
Urgency: low
Maintainer: Debian GCC Maintainers <debian-gcc@lists.debian.org>
Changed-By: Ludovic Brenta <lbrenta@debian.org>
Description: 
 gnat-4.9   - GNU Ada compiler
 gnat-4.9-base - GNU Ada compiler (common files)
 gnat-4.9-sjlj - GNU Ada compiler (setjump/longjump runtime library)
 libgnat-4.9 - runtime for applications compiled with GNAT (shared library)
 libgnat-4.9-dbg - runtime for applications compiled with GNAT (debugging symbols)
 libgnatprj4.9 - GNU Ada compiler Project Manager (shared library)
 libgnatprj4.9-dbg - GNU Ada compiler Project Manager (debugging symbols)
 libgnatprj4.9-dev - GNU Ada compiler Project Manager (development files)
 libgnatvsn4.9 - GNU Ada compiler selected components (shared library)
 libgnatvsn4.9-dbg - GNU Ada compiler selected components (debugging symbols)
 libgnatvsn4.9-dev - GNU Ada compiler selected components (development files)
Closes: 740286
Changes: 
 gnat-4.9 (4.9-20140322-1) experimental; urgency=low
 .
   [Nicolas Boulenguez]
   * debian/control.m4:
     (Suggests): suggest the correct version of ada-reference-manual.
     (Vcs-Svn): specify the publicly accessible repository.
   * Receive debian_packaging.mk from dh-ada-library (not library specific).
   * Receive gnatgcc symlink from gnat (useful outside default compiler).
   * debian/source/local-options: new.
 .
   [Ludovic Brenta]
   * debian/control.m4: conflict with gnat-4.7, gnat-4.8.
   * debian/patches/ada-default-project-path.diff: when passed options such
     as -m32 or -march, do not look for the RTS in
     /usr/share/ada/adainclude but in
     /usr/lib/gcc/$target_triplet/$version/{,rts-}$arch.  Still look
     for project files in /usr/share/ada/adainclude.
   * debian/rules.d/binary-ada.mk, debian/rules.defs, debian/rules.patch:
     Switch to ZCX by default on arm, armel, armhf; built SJLJ as the
     package gnat-4.9-sjlj like on all other architectures.  This is made
     possible by the new upstream version.
   * debian/patches/ada-hurd.diff (s-osinte-gnu.ads): change the type of
     timespec.tv_nsec from long to time_t, for compatibility with
     s-osinte-posix.adb, even though this violates POSIX.  Better solution
     to come from upstream.  Closes: #740286.
 .
   Merge from gcc-4.9 (4.9-20140322-1) experimental; urgency=medium
 .
   * Package GCC 4.9 snapshot 20140322.
     - Fixes build error on the Hurd. Fixes: #740153.
 .
   [Matthias Klose]
   * Re-apply lost patch for config.gcc for mips64el. Fixes: #741543.
Checksums-Sha1: 
 a257105689075e3b6f72a68bf083b3c1dd5f7842 3278 gnat-4.9_4.9-20140322-1.dsc
 f9ad034211311daa6c72230cb8c9a096b037f6af 645735 gnat-4.9_4.9-20140322-1.tar.gz
 351f2f0b52c7b99a5d3a94e9dd24dc8b64515ca2 216770 gnat-4.9-base_4.9-20140322-1_all.deb
 aed38966ce864089d0c4bc24c232d739be42ae64 910752 libgnat-4.9_4.9-20140322-1_amd64.deb
 4078d2d7c1c7940d1f088401fea7d2e18e3274e5 1662016 libgnat-4.9-dbg_4.9-20140322-1_amd64.deb
 e574b9656ce6c454731bd82c712327beb1dea653 1324136 libgnatvsn4.9-dev_4.9-20140322-1_amd64.deb
 457320f51c998de40859a42b07ef04d577922e80 252068 libgnatvsn4.9_4.9-20140322-1_amd64.deb
 a965ef5109db46a5a2058296c0b010fcfa7c0f97 383766 libgnatvsn4.9-dbg_4.9-20140322-1_amd64.deb
 0a95f89e96f4891fbe85a5114e560318d81210e5 3034374 libgnatprj4.9-dev_4.9-20140322-1_amd64.deb
 b44c6aaded74c2545d8f4ac2ae8f6f21df8d88d5 613004 libgnatprj4.9_4.9-20140322-1_amd64.deb
 5acc9700e2dd712ade1ff3df345e6e403512deac 1356214 libgnatprj4.9-dbg_4.9-20140322-1_amd64.deb
 823e4303b5021c6a83e60523e415d75fd3a9da64 9950888 gnat-4.9_4.9-20140322-1_amd64.deb
 b85807c49ce55ce1d1ccdff9c85734e742c37ad2 2986704 gnat-4.9-sjlj_4.9-20140322-1_amd64.deb
Checksums-Sha256: 
 2edd8e537cd37a5cef697dbe04ec2f2c020e90abe437d70613b789ec5c92f0d8 3278 gnat-4.9_4.9-20140322-1.dsc
 9ea74755b80053757f826cd18e3594fc325649b88949c14aa4480947e4b4297b 645735 gnat-4.9_4.9-20140322-1.tar.gz
 f6ba6dff06f8e27c4b74a401839980ec78569635cfa10fdd376a2ff8a4bb7a2c 216770 gnat-4.9-base_4.9-20140322-1_all.deb
 a12c0eeba33422855bcd9d4d7c98a7f820cac3f75c933af61b9c4c001d6c6f77 910752 libgnat-4.9_4.9-20140322-1_amd64.deb
 6672702a4b5f311129da3c26e497801abe65e790a5f8d7c2ec13c6cd58a8f029 1662016 libgnat-4.9-dbg_4.9-20140322-1_amd64.deb
 aa0cc8ea666b16399aae6a3a2a6f05338b011d55c170638a824b9ccaf9fe5c6e 1324136 libgnatvsn4.9-dev_4.9-20140322-1_amd64.deb
 2ce4b55901c873fb1ba73abc2baa90ed4d730072f582e1799693685a3cfaefe2 252068 libgnatvsn4.9_4.9-20140322-1_amd64.deb
 70416af8d490f47b97886622a09a6a0c899e7d763c11cb23f83ca4b074d86db7 383766 libgnatvsn4.9-dbg_4.9-20140322-1_amd64.deb
 c90369cfc3d5fbfa7a84365427b31f8b5552cb898462fc1cbee706de2c81b4df 3034374 libgnatprj4.9-dev_4.9-20140322-1_amd64.deb
 7b5348aaabfd7db5d8634b28f8bd73cfeda34e7283211da6959bea51b8f1bd9c 613004 libgnatprj4.9_4.9-20140322-1_amd64.deb
 ec19649f0aef3e4f2fd01f0d4d65e916bf44c6c4ff7d3fac0005de16887841e3 1356214 libgnatprj4.9-dbg_4.9-20140322-1_amd64.deb
 a6ea837eb4520f1a17585ab1df18775e7582ff037c6842090f1f53f2696fd3af 9950888 gnat-4.9_4.9-20140322-1_amd64.deb
 9e8ef188e3cea480403decedac94599fab8ab3d59f13e010b002cfe87e6b2202 2986704 gnat-4.9-sjlj_4.9-20140322-1_amd64.deb
Files: 
 f948a51ebdf75eb760c8c36b39623533 3278 devel optional gnat-4.9_4.9-20140322-1.dsc
 1d19d2106efbc5717be26ea98ef5ecfa 645735 devel optional gnat-4.9_4.9-20140322-1.tar.gz
 ac1de1ba2636fc4acb824448733bc1aa 216770 libs optional gnat-4.9-base_4.9-20140322-1_all.deb
 2dfda8abd32b5a77a127a5bf2a89ef09 910752 libs optional libgnat-4.9_4.9-20140322-1_amd64.deb
 d3c9129100c33b7f6f6d35cdb75db423 1662016 debug extra libgnat-4.9-dbg_4.9-20140322-1_amd64.deb
 42bdc0b65de12a7551de2406510512ea 1324136 libdevel extra libgnatvsn4.9-dev_4.9-20140322-1_amd64.deb
 eeda1433afeeded1549309e78eaa64e4 252068 libs optional libgnatvsn4.9_4.9-20140322-1_amd64.deb
 0fe7444cd5df4ca19d65a87537ca233b 383766 debug extra libgnatvsn4.9-dbg_4.9-20140322-1_amd64.deb
 c94bce32e3c4d50b26e6459897642e57 3034374 libdevel extra libgnatprj4.9-dev_4.9-20140322-1_amd64.deb
 df8197b4461e40a8e857a243b934d718 613004 libs optional libgnatprj4.9_4.9-20140322-1_amd64.deb
 d91a3d45d5b417ac71b10160e47e751b 1356214 debug extra libgnatprj4.9-dbg_4.9-20140322-1_amd64.deb
 578a23d7df1bb7b5ace7592fb660db1a 9950888 devel optional gnat-4.9_4.9-20140322-1_amd64.deb
 976c5819633e925da656162e4dfabcf9 2986704 devel extra gnat-4.9-sjlj_4.9-20140322-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iD8DBQFTMLeBx9kwJZ3/qtQRAs9IAKCQ1T8vL1Y7kkqiyZeK87ENr0Mz+QCdGtJo
RfMy97LqVPgEBB/IKvGkhko=
=rW0T
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: