[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#730020: marked as done (libffi: FTBFS on powerpcspe: New code breaks port)



Your message dated Thu, 21 Nov 2013 09:34:12 +0000
with message-id <E1VjQeK-0003jJ-Ot@franck.debian.org>
and subject line Bug#730020: fixed in libffi 3.0.13-6
has caused the Debian Bug report #730020,
regarding libffi: FTBFS on powerpcspe: New code breaks port
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
730020: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=730020
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: libffi
Version: 3.0.13-5
Severity: wishlist
Tags: patch sid
User: debian-powerpcspe@breakpoint.cc
Usertags: powerpcspe

Hi,

libffi currently FTBFS on powerpcspe like this:

...
libtool: compile:  powerpc-linux-gnuspe-gcc -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude -I../src -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -fexceptions -MT src/powerpc/ffi.lo -MD -MP -MF src/powerpc/.deps/ffi.Tpo -c ../src/powerpc/ffi.c  -fPIC -DPIC -o src/powerpc/.libs/ffi.o
../src/powerpc/ffi.c: In function 'ffi_prep_cif_machdep_core':
../src/powerpc/ffi.c:981:24: error: 'NUM_FPR_ARG_REGISTERS' undeclared (first use in this function)
../src/powerpc/ffi.c:981:24: note: each undeclared identifier is reported only once for each function it appears in
../src/powerpc/ffi.c: In function 'ffi_closure_helper_LINUX64':
../src/powerpc/ffi.c:1797:25: error: 'FLAG_RETURNS_FP' undeclared (first use in this function)
make[3]: *** [src/powerpc/ffi.lo] Error 1
make[3]: Leaving directory `/«PKGBUILDDIR»/build'
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [stamp-build] Error 2
...

The codebase supports powerpcspe already, but some recent changes broke it.
Attaching a patch that fixes it via the __NO_FPRS__ conditionals already used
in all the other powerpcspe specific places.

Roland


-- System Information:
Debian Release: 7.0
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: powerpcspe (ppc)

Kernel: Linux 3.9.0-dirty (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
Index: libffi-3.0.13/src/powerpc/ffi.c
===================================================================
--- libffi-3.0.13.orig/src/powerpc/ffi.c	2013-11-20 07:24:56.000000000 +0100
+++ libffi-3.0.13/src/powerpc/ffi.c	2013-11-20 07:32:16.639021999 +0100
@@ -974,6 +974,7 @@
 
 	switch ((*ptr)->type)
 	  {
+#ifndef __NO_FPRS__
 #if FFI_TYPE_LONGDOUBLE != FFI_TYPE_DOUBLE
 	  case FFI_TYPE_LONGDOUBLE:
 	    fparg_count += 2;
@@ -989,7 +990,7 @@
 	    if (fparg_count > NUM_FPR_ARG_REGISTERS)
 	      flags |= FLAG_ARG_NEEDS_PSAVE;
 	    break;
-
+#endif
 	  case FFI_TYPE_STRUCT:
 #ifdef __STRUCT_PARM_ALIGN__
 	    align = (*ptr)->alignment;
@@ -1004,6 +1005,7 @@
 #if _CALL_ELF == 2
 	    elt = discover_homogeneous_aggregate (*ptr, &elnum);
 #endif
+#ifndef __NO_FPRS__
 	    if (elt)
 	      {
 		fparg_count += elnum;
@@ -1011,6 +1013,7 @@
 		  flags |= FLAG_ARG_NEEDS_PSAVE;
 	      }
 	    else
+#endif
 	      {
 		if (intarg_count > NUM_GPR_ARG_REGISTERS)
 		  flags |= FLAG_ARG_NEEDS_PSAVE;
@@ -1794,9 +1797,12 @@
   /* Tell ffi_closure_LINUX64 how to perform return type promotions.  */
   if ((cif->flags & FLAG_RETURNS_SMST) != 0)
     {
+#ifndef __NO_FPRS__
       if ((cif->flags & FLAG_RETURNS_FP) == 0)
 	return FFI_V2_TYPE_SMALL_STRUCT + cif->rtype->size - 1;
-      else if ((cif->flags & FLAG_RETURNS_64BITS) != 0)
+      else
+#endif
+      if ((cif->flags & FLAG_RETURNS_64BITS) != 0)
 	return FFI_V2_TYPE_DOUBLE_HOMOG;
       else
 	return FFI_V2_TYPE_FLOAT_HOMOG;

--- End Message ---
--- Begin Message ---
Source: libffi
Source-Version: 3.0.13-6

We believe that the bug you reported is fixed in the latest version of
libffi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 730020@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthias Klose <doko@debian.org> (supplier of updated libffi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 21 Nov 2013 10:17:22 +0100
Source: libffi
Binary: libffi-dev lib32ffi-dev lib64ffi-dev libn32ffi-dev libffi6 lib32ffi6 lib64ffi6 libn32ffi6 libffi6-dbg libffi6-udeb
Architecture: source amd64
Version: 3.0.13-6
Distribution: unstable
Urgency: low
Maintainer: Debian GCC Maintainers <debian-gcc@lists.debian.org>
Changed-By: Matthias Klose <doko@debian.org>
Description: 
 lib32ffi-dev - Foreign Function Interface library (development files, 32bit)
 lib32ffi6  - Foreign Function Interface library runtime (32bit)
 lib64ffi-dev - Foreign Function Interface library (development files, 64bit)
 lib64ffi6  - Foreign Function Interface library runtime (64bit)
 libffi-dev - Foreign Function Interface library (development files)
 libffi6    - Foreign Function Interface library runtime
 libffi6-dbg - Foreign Function Interface library runtime (debug symbols)
 libffi6-udeb - Foreign Function Interface library runtime (udeb)
 libn32ffi-dev - Foreign Function Interface library (development files, n32)
 libn32ffi6 - Foreign Function Interface library runtime (n32)
Closes: 730020 730021
Changes: 
 libffi (3.0.13-6) unstable; urgency=low
 .
   * Add symbols file for powerpcspe. Closes: #730021.
   * Don't apply the powerpc ABIv2 patch for now. Closes: #730020.
Checksums-Sha1: 
 aedea77177af820ccced4570def2b43c720d5a13 1619 libffi_3.0.13-6.dsc
 d6d8e20b038330a53410eb77b188c6283e0febc3 28353 libffi_3.0.13-6.debian.tar.gz
 dd78f663b2a5e6dc5c52e62c8534262e4e66c560 99840 libffi-dev_3.0.13-6_amd64.deb
 943f2994d6b63c7507b0231dbb48027164a0df4d 23516 lib32ffi-dev_3.0.13-6_amd64.deb
 89999ecbdafd9a5c14d5b35825a0bafcb9e942b4 19202 libffi6_3.0.13-6_amd64.deb
 f3dca16f31697180bc9630fa80fabacb09974c65 16192 lib32ffi6_3.0.13-6_amd64.deb
 42d0d0e09708bffcb1c85163fb58bf673ac23fb2 30066 libffi6-dbg_3.0.13-6_amd64.deb
 bcb1eaece33e62650fc5a714a25425708ff943ea 14414 libffi6-udeb_3.0.13-6_amd64.udeb
Checksums-Sha256: 
 1797cf13bdbbe5d676ceded396e1822fb13785aa62624734c8d5bd42da2b1d9a 1619 libffi_3.0.13-6.dsc
 1de44047588ab2252b06f7afaebd8247d49dfbf06def1d261f173a5e738bcf0e 28353 libffi_3.0.13-6.debian.tar.gz
 250c958eee3feb779850b66c3616ac0efeec12451a9c7ecfd922cfb1b4d39b48 99840 libffi-dev_3.0.13-6_amd64.deb
 e2a0dc69d5836d2d444e084e600f193650498642efc62d60ae5a5888c32aaeec 23516 lib32ffi-dev_3.0.13-6_amd64.deb
 c84c2313908cadd9dadb0b17cd186db771ca30b42b2941823ae25fc87027cd1a 19202 libffi6_3.0.13-6_amd64.deb
 bd008898bd0d1631eecda42801a1ac45ffcd656150e38c534e2dc4cdd52a57fa 16192 lib32ffi6_3.0.13-6_amd64.deb
 6d7c7b7ee74f9742a97890543f0584f304da98143e5f58a1d5e7553037935e87 30066 libffi6-dbg_3.0.13-6_amd64.deb
 00f8f54ddfc95d472397f7af89347aa337f14cfc3c25cf19be8deee73faedfe6 14414 libffi6-udeb_3.0.13-6_amd64.udeb
Files: 
 544b321d37cb9328f01d75e1be0b7c43 1619 libs optional libffi_3.0.13-6.dsc
 bc47bfad83df7ae963995cd095bfbf18 28353 libs optional libffi_3.0.13-6.debian.tar.gz
 d8e26128434362f7d7ad5850b0ffd88e 99840 libdevel optional libffi-dev_3.0.13-6_amd64.deb
 7f0e2556a127d8d714f7e0e513ecd377 23516 libdevel extra lib32ffi-dev_3.0.13-6_amd64.deb
 0374e71482a55bd4a68b966bc4ad08d0 19202 libs optional libffi6_3.0.13-6_amd64.deb
 e6aec982c19efdf5faa3a33c6cff1956 16192 libs extra lib32ffi6_3.0.13-6_amd64.deb
 8b5e90474d9c824a0667ab23c60d38fd 30066 debug extra libffi6-dbg_3.0.13-6_amd64.deb
 22dfe70ee31da897a56a617aa8c49643 14414 debian-installer optional libffi6-udeb_3.0.13-6_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEARECAAYFAlKN0rwACgkQStlRaw+TLJwGNACgwDVJDe6WbaeAmH5SItt2VFCE
baUAnj4YBLEETfgM+PRKUqcS/PyyojkY
=DDL6
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: