[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#511491: [BTS 511491] Need patch review



Am Montag, den 09.03.2009, 20:49 +0100 schrieb Damien Raude-Morvan:

> I'm looking for someone who can review patch attached to this bug report [1].
> I've applyed it locally and it seems to work fine but I'm not specialist in 
> java-gcj-compat

Well, the main point is, that rebuild-gcj-db is called with the full
path prepended. The aim is to avoid this.

>  and may not see some corner cases.

I would probably use

if [ -x "`which rebuild-gcj-db 2>/dev/null`" ]; then rebuild-gcj-db ; fi

and don't add the explicit dependency (this is used by many (most?) apps
added by debhelper scripts).

However, the patch suggested by Jan is ok. But it will break things as
soon as the dependency path does not provide rebuild-gcj-db.

Regards, Daniel




Reply to: