[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#472854: gnat-4.3 needs a manual build for mips and mipsel



On Sun, Apr 06, 2008 at 09:16:38PM +0200, grave@ipno.in2p3.fr wrote:
> > On Tue, Apr 01, 2008 at 10:44:33PM +0200, Ludovic Brenta wrote:
> >> Aurelien Jarno writes:
> >> > I have just checked-in a patch in the SVN to fix this problem.
> >>
> >> Thanks a lot! I'll upload it as part of 4.3.0-3 immediately after
> >> gcc-4.3 4.3.0-3.
> >>
> >> > BTW is there any reason to keep the MIPS support as a Debian patch
> >> > instead of forwarding it upstream? This problem would probably have
> >> > been avoided.
> >>
> >> Yes, there is a reason but it's a very bad one: lack of time to engage
> >> into the copyright-assignment procedure.  The author of the mips
> >> support, Xavier Grave, is an occasional contributor to the Debian
> >> packages and has never contributed to GCC yet (CCing him).
> >>
> >> As a first step, since he now has a little time available, I've asked
> >> him to separate the mips support into a patch independent of ada-sjlj.
> >> That should make future submission to upstream easier.
> >
> > I have seen this is now done, and I have made a few more changes to get
> > the MIPS support fully working.
> 
> In order to improve my knowledge about porting gnat to new architecture
> can you describe what you have modified please ?

I basically added parts which have been added to other target but not
for MIPS as it is not in the SVN. You will find the diff below. 

Index: ada-mips.dpatch
===================================================================
--- ada-mips.dpatch	(révision 3002)
+++ ada-mips.dpatch	(copie de travail)
@@ -28,7 +28,7 @@
 ===================================================================
 --- gcc/ada/Makefile.in.orig	2008-04-04 11:17:38.721366234 +0200
 +++ gcc/ada/Makefile.in	2008-04-04 11:20:47.530513605 +0200
-@@ -1362,6 +1362,28 @@
+@@ -1362,6 +1362,30 @@
    LIBRARY_VERSION := $(LIB_VERSION)
  endif
  
@@ -42,6 +42,8 @@
 +  s-osinte.ads<s-osinte-linux.ads \
 +  s-osprim.adb<s-osprim-posix.adb \
 +  s-taprop.adb<s-taprop-linux.adb \
++  s-tasinf.ads<s-tasinf-linux.ads \
++  s-tasinf.adb<s-tasinf-linux.adb \
 +  s-taspri.ads<s-taspri-posix.ads \
 +  s-tpopsp.adb<s-tpopsp-posix-foreign.adb \
 +  system.ads<system-linux-mips.ads
@@ -61,7 +63,7 @@
 ===================================================================
 --- /dev/null	1970-01-01 00:00:00.000000000 +0000
 +++ gcc/ada/g-soccon-linux-mips.ads	2008-04-04 11:30:39.374783493 +0200
-@@ -0,0 +1,183 @@
+@@ -0,0 +1,197 @@
 +------------------------------------------------------------------------------
 +--                                                                          --
 +--                         GNAT COMPILER COMPONENTS                         --
@@ -206,7 +208,8 @@
 +   MSG_PEEK           : constant :=            2; --  Peek at incoming data
 +   MSG_EOR            : constant :=          128; --  Send end of record
 +   MSG_WAITALL        : constant :=          256; --  Wait for full reception
-+   gs   : constant := MSG_NOSIGNAL;
++   MSG_NOSIGNAL       : constant :=        16384; --  No SIGPIPE on send
++   MSG_Forced_Flags   : constant := MSG_NOSIGNAL;
 +   --  Flags set on all send(2) calls
 +
 +   --------------------
@@ -244,6 +247,19 @@
 +   SIZEOF_tv_sec      : constant :=            4; --  tv_sec
 +   SIZEOF_tv_usec     : constant :=            4; --  tv_usec
 +
++   ----------------------------------------
++   -- Properties of supported interfaces --
++   ----------------------------------------
++
++   Need_Netdb_Buffer  : constant :=            1; --  Need buffer for Netdb ops
++
++   ----------------------
++   -- Additional flags --
++   ----------------------
++
++   Thread_Blocking_IO : constant Boolean := True;
++   --  Set False for contexts where socket i/o are process blocking
++
 +end GNAT.Sockets.Constants;
 Index: gcc/ada/system-linux-mips.ads
 ===================================================================
Index: ada-mipsel.dpatch
===================================================================
--- ada-mipsel.dpatch	(révision 3002)
+++ ada-mipsel.dpatch	(copie de travail)
@@ -28,7 +28,7 @@
 ===================================================================
 --- gcc/ada/Makefile.in.orig	2008-04-04 11:33:17.995925666 +0200
 +++ gcc/ada/Makefile.in	2008-04-04 11:33:58.156214700 +0200
-@@ -1384,6 +1384,28 @@
+@@ -1384,6 +1384,30 @@
    LIBRARY_VERSION := $(LIB_VERSION)
  endif
  
@@ -42,6 +42,8 @@
 +  s-osinte.ads<s-osinte-linux.ads \
 +  s-osprim.adb<s-osprim-posix.adb \
 +  s-taprop.adb<s-taprop-linux.adb \
++  s-tasinf.ads<s-tasinf-linux.ads \
++  s-tasinf.adb<s-tasinf-linux.adb \
 +  s-taspri.ads<s-taspri-posix.ads \
 +  s-tpopsp.adb<s-tpopsp-posix-foreign.adb \
 +  system.ads<system-linux-mipsel.ads

> > I have copyright-assignements for GCC, we can probably submit this patch
> > with both our names if you agree.
> 
> OK for me.

I'll submit it later today.

Cheers,
Aurelien

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net



Reply to: