[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#453267: tested patch



On Sun, 09 Dec 2007, Neil Williams wrote:
> > I'm ok with a
> > supplementary specific check for building of a cross-compiler, but not
> > with a generic check like testing the ARCH environment variable.
> 
> OK, I have a solution for that - replace $ARCH with $GCC_TARGET.
> 
> I've tested with this change to the patch for scripts/Dpkg/Shlibs.pm
> 
> # GCC_TARGET for cross compiler builds
> my $crossprefix = Dpkg::Arch::debarch_to_gnutriplet($ENV{GCC_TARGET}) if
> ($ENV{GCC_TARGET});
> ...
> 
> I went for ARCH before because, in the context of building a cross
> compiler, ARCH is only set at certain times. GCC_TARGET is set at the
> beginning and is present throughout the build. 

If I understand you correctly, we can check for GCC_TARGET only and we
don't need to check DEB_TARGET_GNU_TYPE != DEB_BUILD_GNU_TYPE.

Is that correct and does that work ?

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



Reply to: