Bug#433172: error in debian/rules.defs: ssp_no_archs when DEB_CROSS defined can't be used because ssp_no_archs variable is redefined right after

["Arthur Loiret" <arthur.loiret@gmail.com>]

Package: gcc-4.2
Version: 4.2-20070712

Hello,

In debian/rules.defs I read

ifdef DEB_CROSS
 ssp_no_archs = arm armel alpha hppa ia64 m68k mips mipsel hurd-i386
endif
ssp_no_archs = alpha hppa ia64 m68k mips mipsel hurd-i386

which mean that ssp_no_archs is always the same as it is redefined after.

It could be replaced by:

ssp_no_archs = alpha hppa ia64 m68k mips mipsel hurd-i386
ifdef DEB_CROSS
 ssp_no_archs += arm armel
endif

A patch is joined to this mail.

Have a nice day,

Arthur.

--- rules.defs	2007-07-15 06:04:23.000000000 +0000
+++ ../debian/rules.defs	2007-07-15 06:14:50.000000000 +0000
@@ -399,10 +399,10 @@
 
 # libssp -------------------
 with_ssp := yes
+ssp_no_archs = alpha hppa ia64 m68k mips mipsel hurd-i386
 ifdef DEB_CROSS
-  ssp_no_archs = arm armel alpha hppa ia64 m68k mips mipsel hurd-i386
+  ssp_no_archs += arm armel
 endif
-ssp_no_archs = alpha hppa ia64 m68k mips mipsel hurd-i386
 ifneq (, $(filter $(DEB_TARGET_ARCH),$(ssp_no_archs)))
   with_ssp := not available on $(DEB_TARGET_ARCH)
 endif