[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#348792: 64-bit unclean logic found in _Jv_ulp

reassign 348792 libgcj7-0
tags 348792 + patch

In the light of your recent pull of classpath 0.92, I took another
look at this bug.  The bad news is that it's still present; the good
news is that I've found a fix, per the below patch (without which the
test for L < 0 always fails on 64-bit systems).  Could you please
apply it, and push it upstream, when you get a chance?


--- src/libjava/classpath/native/fdlibm/mprec.c~	2006-09-05 09:47:02.000000000 -0400
+++ src/libjava/classpath/native/fdlibm/mprec.c	2006-09-05 13:15:28.000000000 -0400
@@ -666,7 +666,7 @@
 _DEFUN (ulp, (_x), double _x)
   union double_union x, a;
-  register __Long L;
+  register int32_t L;
   x.d = _x;

Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
Finger amu@monk.mit.edu (NOT a valid e-mail address) for more info.

Reply to: