[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#310167: marked as done (gcc-3.3: debian/patches/autoreconf.dpatch does not fail on error)



Your message dated Tue, 28 Jun 2005 01:10:33 +0200
with message-id <17088.34665.593377.220845@gargle.gargle.HOWL>
and subject line Bug#310167: gcc-3.3: debian/patches/autoreconf.dpatch does not fail on error
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 22 May 2005 08:23:00 +0000
>From brederlo@informatik.uni-tuebingen.de Sun May 22 01:23:00 2005
Return-path: <brederlo@informatik.uni-tuebingen.de>
Received: from mx4.informatik.uni-tuebingen.de [134.2.12.29] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DZljg-0002za-00; Sun, 22 May 2005 01:23:00 -0700
Received: from localhost (loopback [127.0.0.1])
	by mx4.informatik.uni-tuebingen.de (Postfix) with ESMTP
	id 19C4D150D; Sun, 22 May 2005 10:22:28 +0200 (DFT)
Received: from mx4.informatik.uni-tuebingen.de ([127.0.0.1])
 by localhost (mx4 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 23880-01; Sun, 22 May 2005 10:22:26 +0200 (DFT)
Received: from localhost.localdomain (semeai.Informatik.Uni-Tuebingen.De [134.2.15.66])
	by mx4.informatik.uni-tuebingen.de (Postfix) with ESMTP
	id 3827F1510; Sun, 22 May 2005 10:22:26 +0200 (DFT)
Received: from mrvn by localhost.localdomain with local (Exim 4.50)
	id 1DZlj2-00024k-Ts; Sun, 22 May 2005 10:22:20 +0200
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Goswin Brederlow <brederlo@informatik.uni-tuebingen.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: gcc-3.3: debian/patches/autoreconf.dpatch does not fail on error
X-Mailer: reportbug 3.9
Date: Sun, 22 May 2005 10:22:20 +0200
Message-Id: <E1DZlj2-00024k-Ts@localhost.localdomain>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: gcc-3.3
Version: 1:3.3.5-12
Severity: important
Justification: fails to build from source

Hi,

I'm trying to rebuild gcc-3.3 in sarge to track another bug and I got
a FTBFS on my normal system. I tried again in my buildd chroot and
there it works.

Comparing the build logs I found:

| DEB_VERSION='1:3.3.5-12'; export DEB_VERSION; \
| debian/patches/autoreconf.dpatch -patch -d /mnt/mirror/gcc-3.3/gcc-3.3-3.3.5/src
| patching file libtool.m4
| FATAL ERROR: Autoconf version 2.50 or higher is required for this script
| FATAL ERROR: Autoconf version 2.50 or higher is required for this script
| FATAL ERROR: Autoconf version 2.50 or higher is required for this script
| FATAL ERROR: Autoconf version 2.50 or higher is required for this script
| FATAL ERROR: Autoconf version 2.50 or higher is required for this script
| echo "autoreconf patches applied." > stamps/02-patch-stamp-autoreconf


But the bug isn't about it failing for some mysterious reason, I'm
looking into that seperately, but about not stoping the build on this
error. The problem is that, while -e is set in the dpatch, it does not
affect subshells:

|    -patch)
|        patch $pdir -f --no-backup-if-mismatch -p0 < $0
|        for i in libf2c libjava/libltdl libobjc libstdc++-v3 zlib; do
|                (cd ${dir}/${i} ; autoreconf --force)
|        done
|        ;;

() forks a new shell and return code of subshells != 0 don't abbort:

mrvn@frosties:~% sh -c "set -e; for i in a b; do echo \$i; false; done" 
a
mrvn@frosties:~% sh -c "set -e; for i in a b; do ( echo \$i; false ); echo \$?; done"  
a
1
b
1

You have to manually check the return code of the subshell and take
action, e.g. call false or exit:

mrvn@frosties:~% sh -c "set -e; for i in a b; do ( echo \$i; false ) || false; done"       
a

MfG
	Goswin


-- System Information:
Debian Release: 3.1
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.8-frosties-1
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages gcc-3.3 depends on:
ii  binutils                    2.15-5       The GNU assembler, linker and bina
ii  cpp-3.3                     1:3.3.5-12   The GNU C preprocessor
ii  gcc-3.3-base                1:3.3.5-12   The GNU Compiler Collection (base 
ii  libc6                       2.3.2.ds1-21 GNU C Library: Shared libraries an
ii  libgcc1                     1:3.4.3-12   GCC support library

-- no debconf information

---------------------------------------
Received: (at 310167-done) by bugs.debian.org; 27 Jun 2005 23:10:38 +0000
>From doko@cs.tu-berlin.de Mon Jun 27 16:10:38 2005
Return-path: <doko@cs.tu-berlin.de>
Received: from mail.cs.tu-berlin.de [130.149.17.13] (root)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Dn2kQ-0004Tk-00; Mon, 27 Jun 2005 16:10:38 -0700
Received: from mailhost.cs.tu-berlin.de (postfix@mail.cs.tu-berlin.de [130.149.17.13])
	by mail.cs.tu-berlin.de (8.9.3p2/8.9.3) with ESMTP id BAA24080;
	Tue, 28 Jun 2005 01:10:35 +0200 (MEST)
Received: from localhost (localhost [127.0.0.1])
	by mailhost.cs.tu-berlin.de (Postfix) with ESMTP id 5D48AF2B9;
	Tue, 28 Jun 2005 01:10:35 +0200 (MEST)
Received: from mailhost.cs.tu-berlin.de ([127.0.0.1])
 by localhost (bueno [127.0.0.1]) (amavisd-new, port 10224) with ESMTP
 id 23095-25; Tue, 28 Jun 2005 01:10:33 +0200 (MEST) 11343
Received: from bolero.cs.tu-berlin.de (bolero.cs.tu-berlin.de [130.149.19.1])
	by mailhost.cs.tu-berlin.de (Postfix) with ESMTP;
	Tue, 28 Jun 2005 01:10:33 +0200 (MEST)
Received: (from doko@localhost)
	by bolero.cs.tu-berlin.de (8.12.10+Sun/8.12.8/Submit) id j5RNAXPi015141;
	Tue, 28 Jun 2005 01:10:33 +0200 (MEST)
From: Matthias Klose <doko@cs.tu-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17088.34665.593377.220845@gargle.gargle.HOWL>
Date: Tue, 28 Jun 2005 01:10:33 +0200
To: Goswin Brederlow <brederlo@informatik.uni-tuebingen.de>,
        310167-done@bugs.debian.org
Subject: Re: Bug#310167: gcc-3.3: debian/patches/autoreconf.dpatch does not fail on error
In-Reply-To: <E1DZlj2-00024k-Ts@localhost.localdomain>
References: <E1DZlj2-00024k-Ts@localhost.localdomain>
X-Mailer: VM 7.17 under 21.4 (patch 17) "Jumbo Shrimp" XEmacs Lucid
X-Virus-Scanned: by amavisd-new at cs.tu-berlin.de
Delivered-To: 310167-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

the patch was removed.

Goswin Brederlow writes:
> Package: gcc-3.3
> Version: 1:3.3.5-12
> Severity: important
> Justification: fails to build from source
> 
> Hi,
> 
> I'm trying to rebuild gcc-3.3 in sarge to track another bug and I got
> a FTBFS on my normal system. I tried again in my buildd chroot and
> there it works.
> 
> Comparing the build logs I found:
> 
> | DEB_VERSION='1:3.3.5-12'; export DEB_VERSION; \
> | debian/patches/autoreconf.dpatch -patch -d /mnt/mirror/gcc-3.3/gcc-3.3-3.3.5/src
> | patching file libtool.m4
> | FATAL ERROR: Autoconf version 2.50 or higher is required for this script
> | FATAL ERROR: Autoconf version 2.50 or higher is required for this script
> | FATAL ERROR: Autoconf version 2.50 or higher is required for this script
> | FATAL ERROR: Autoconf version 2.50 or higher is required for this script
> | FATAL ERROR: Autoconf version 2.50 or higher is required for this script
> | echo "autoreconf patches applied." > stamps/02-patch-stamp-autoreconf
> 
> 
> But the bug isn't about it failing for some mysterious reason, I'm
> looking into that seperately, but about not stoping the build on this
> error. The problem is that, while -e is set in the dpatch, it does not
> affect subshells:
> 
> |    -patch)
> |        patch $pdir -f --no-backup-if-mismatch -p0 < $0
> |        for i in libf2c libjava/libltdl libobjc libstdc++-v3 zlib; do
> |                (cd ${dir}/${i} ; autoreconf --force)
> |        done
> |        ;;
> 
> () forks a new shell and return code of subshells != 0 don't abbort:
> 
> mrvn@frosties:~% sh -c "set -e; for i in a b; do echo \$i; false; done" 
> a
> mrvn@frosties:~% sh -c "set -e; for i in a b; do ( echo \$i; false ); echo \$?; done"  
> a
> 1
> b
> 1
> 
> You have to manually check the return code of the subshell and take
> action, e.g. call false or exit:
> 
> mrvn@frosties:~% sh -c "set -e; for i in a b; do ( echo \$i; false ) || false; done"       
> a
> 
> MfG
> 	Goswin
> 
> 
> -- System Information:
> Debian Release: 3.1
> Architecture: amd64 (x86_64)
> Kernel: Linux 2.6.8-frosties-1
> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
> 
> Versions of packages gcc-3.3 depends on:
> ii  binutils                    2.15-5       The GNU assembler, linker and bina
> ii  cpp-3.3                     1:3.3.5-12   The GNU C preprocessor
> ii  gcc-3.3-base                1:3.3.5-12   The GNU Compiler Collection (base 
> ii  libc6                       2.3.2.ds1-21 GNU C Library: Shared libraries an
> ii  libgcc1                     1:3.4.3-12   GCC support library
> 
> -- no debconf information
> 
> 
> -- 
> To UNSUBSCRIBE, email to debian-gcc-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org



Reply to: