[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#218566: [BIO] Bounce queue in bio_add_page



On Fri, Nov 07, 2003 at 12:32:35PM +0100, Jens Axboe wrote:
> On Fri, Nov 07 2003, Herbert Xu wrote:
> > On Fri, Nov 07, 2003 at 12:25:55PM +0100, Jens Axboe wrote:
> > > 
> > > Could be related, someone is doing an unlock on an already unlocked
> > > page. Is this the same system that saw the bounce problem initially?
> > 
> > Yes, see http://bugs.debian.org/218566 for details.
> 
> Then there's likely just some other bug wrt bouncing. Hmm, does this
> work?
> 
> ===== mm/highmem.c 1.47 vs edited =====
> --- 1.47/mm/highmem.c	Thu Oct  9 15:03:32 2003
> +++ edited/mm/highmem.c	Fri Nov  7 12:32:03 2003
> @@ -402,6 +402,8 @@
>  		to->bv_len = from->bv_len;
>  		to->bv_offset = from->bv_offset;
>  
> +		lock_page(to->bv_page);
> +
>  		if (rw == WRITE) {
>  			char *vto, *vfrom;

Hi Shaul:

Please check if this patch fixes your last crash.

Thanks,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Reply to: