clarification of fix (fwd)

[Adrian Bunk <bunk@fs.tum.de>]

Hi,

this is the second mail Jack sent me.

cu
Adrian


---------- Forwarded message ----------
Date: Tue, 1 May 2001 22:50:22 -0400 (EDT)
From: Jack Howarth <howarth@bromo.med.uc.edu>
To: bunk@fs.tum.de
Subject: clarification of fix

Adrian,
   After looking at what patches from Franz Sirl you currently install
in gcc-2.95.4, I believe the following is all you need to create gcc
packages that can compile the current glibc 2.2.3...

--- gcc/varasm.c.org    Tue May  1 22:35:43 2001
+++ gcc/varasm.c        Tue May  1 22:48:42 2001
@@ -4350,10 +4350,15 @@
 {
   if (! TREE_PUBLIC (decl))
     error_with_decl (decl, "weak declaration of `%s' must be public");
+#if 0
+  /* Due to a bug this error was never active, enabling it now would break
+   glibc.  */
   else if (TREE_ASM_WRITTEN (decl))
     error_with_decl (decl, "weak declaration of `%s' must precede definition");
+  /* This would be a new error, but it would break glibc too :-(.  */
   else if (TREE_USED (decl))
     error_with_decl (decl, "weak declaration of `%s' must precede its uses");
+#endif
   else if (SUPPORTS_WEAK)
     DECL_WEAK (decl) = 1;
 #ifdef HANDLE_PRAGMA_WEAK

I would build some test gcc packages on my debian ppc box but the
packaging looks pretty complex so I'm not sure how to embed this patch
in the build.
    Of course this is a hack until a proper fix arrives but it Franz
seems to think its okay for now.
                                 Jack