[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#899124: [openstack-dev] [horizon] Font awesome currently broken with Debian Sid and Horizon



Hi Thomas,
 
As my python3-xstatic-font-awesome removes the embedded fonts

It sounds like you broke xstatic-* packages for Debian and use something we don't test with Horizon at all.

Speaking about Rocky/master version, our upper-constraint XStatic-Font-Awesome===4.7.0.0 [1]. We don't test horizon with font awesome v 5.0.10.


Second, it'd be nice if Horizon could adapt and use the new v5
font-awesome, so that the problem is completely solved.
+1. I'll put my +2/A once somebody provides a patch for it with a detailed description how can I test it. Unfortunately, Horizon team has a very limited set of resources, so we can't adopt new version of xstatic-* fast :(.

[1] https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L61

Regards,
Ivan Kolodyazhny,
http://blog.e0ne.info/

On Wed, May 30, 2018 at 4:27 PM, Thomas Goirand <thomas@goirand.fr> wrote:
Hi Radomir,

I'm adding the debian bug as Cc.

On 05/28/2018 08:35 AM, Radomir Dopieralski wrote:
> I did a quick search for all the glyphs we are using:
>
> ~/dev/horizon(master)> ag 'fa-' | egrep -o 'fa-[a-z-]*' | sort | uniq
> fa-
> fa-angle-left
> [...]

Thanks for your investigation.

I did a quick test, and loaded all of these glyphs into a test HTML
page. As much as I can see, only 4 glyphs aren't in fa-solid-900:

fa-cloud-upload
fa-pencil
fa-share-square-o
fa-sign-out

It'd be nice if we could replace these by glyphs present in fa-solid-900
so we could simply replace the old v4 font by fa-solid-900 only.

Your thoughts?

Cheers,

Thomas Goirand (zigo)

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Reply to: