[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659716: marked as done (ttf-georgewilliams: use dh_installdeb maintscript support)

Your message dated Fri, 29 Aug 2014 04:00:19 +0000
with message-id <E1XNDMJ-0005aU-8r@franck.debian.org>
and subject line Bug#659716: fixed in fonts-georgewilliams 20031023-1
has caused the Debian Bug report #659716,
regarding ttf-georgewilliams: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659716: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659716
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: ttf-georgewilliams
Version: 1.0-5
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
ttf-georgewilliams.  This seems generally undesirable; it would be
better to enforce a single code path.  (This is academic for Debian
because the version of dpkg in squeeze supported
dpkg-maintscript-helper, hence Severity: wishlist; Ubuntu's last LTS
release didn't have a sufficient version of dpkg for that which is why I
care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru gw-fonts-ttf-1.0/debian/control gw-fonts-ttf-1.0/debian/control
--- gw-fonts-ttf-1.0/debian/control	2011-07-21 17:19:34.000000000 +0100
+++ gw-fonts-ttf-1.0/debian/control	2012-02-13 12:33:26.000000000 +0000
@@ -3,12 +3,13 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Christian Perrier <bubulle@debian.org>
-Build-Depends: debhelper (>= 8), unzip
+Build-Depends: debhelper (>= 8.1.0~), unzip
 Homepage: http://fontforge.sourceforge.net/sfds/
 Standards-Version: 3.9.2
 
 Package: ttf-georgewilliams
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Description: Free unicode TrueType fonts by George Williams
  A set of Free unicode True Type fonts made by George Williams.
diff -Nru gw-fonts-ttf-1.0/debian/maintscript gw-fonts-ttf-1.0/debian/maintscript
--- gw-fonts-ttf-1.0/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ gw-fonts-ttf-1.0/debian/maintscript	2012-02-13 12:32:58.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-georgewilliams.hints 1.0-5
diff -Nru gw-fonts-ttf-1.0/debian/postinst gw-fonts-ttf-1.0/debian/postinst
--- gw-fonts-ttf-1.0/debian/postinst	2011-07-21 16:17:13.000000000 +0100
+++ gw-fonts-ttf-1.0/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-georgewilliams.hints 1.0-5 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru gw-fonts-ttf-1.0/debian/postrm gw-fonts-ttf-1.0/debian/postrm
--- gw-fonts-ttf-1.0/debian/postrm	2011-07-21 16:17:25.000000000 +0100
+++ gw-fonts-ttf-1.0/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-georgewilliams.hints 1.0-5 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru gw-fonts-ttf-1.0/debian/preinst gw-fonts-ttf-1.0/debian/preinst
--- gw-fonts-ttf-1.0/debian/preinst	2011-07-21 16:17:44.000000000 +0100
+++ gw-fonts-ttf-1.0/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-georgewilliams.hints 1.0-5 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-georgewilliams
Source-Version: 20031023-1

We believe that the bug you reported is fixed in the latest version of
fonts-georgewilliams, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659716@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Francesca Ciceri <madamezou@debian.org> (supplier of updated fonts-georgewilliams package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 14 May 2014 17:20:47 +0200
Source: fonts-georgewilliams
Binary: fonts-georgewilliams ttf-georgewilliams
Architecture: source all
Version: 20031023-1
Distribution: unstable
Urgency: low
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Francesca Ciceri <madamezou@debian.org>
Description: 
 fonts-georgewilliams - Free unicode TrueType fonts by George Williams
 ttf-georgewilliams - transitional dummy package
Closes: 434624 659716
Changes: 
 fonts-georgewilliams (20031023-1) unstable; urgency=low
 .
   * Team upload
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
     new enough version of dpkg rather than using 'dpkg-maintscript-helper
     supports' guards, leading to more predictable behaviour on upgrade.
     Thanks Colin Watson for the patch. Closes: #659716
   * Use git for packaging: added Vcs-Git and Vcs-Browser fields
   * Add Multi-Arch: foreign field
   * Rename source package to "fonts-georgewilliams" to fit the Font Packages
     Naming Policy
   * bumped debhelper compatibility
   * bumped standard version to 3.9.5 (checked)
   * new release, based on most recent upstream version. Closes: #434624
Checksums-Sha1: 
 ca9c6c57f9ce8c341b1cbf345404c3405b155e7e 2200 fonts-georgewilliams_20031023-1.dsc
 94d5939348ff55c17dd8460c4fd6904f40a0a0f9 2849104 fonts-georgewilliams_20031023.orig.tar.xz
 7ccb0f1cd1f64dd58fccdfd648247837261c4c28 4996 fonts-georgewilliams_20031023-1.debian.tar.xz
 1a43b0823b5e10e86a2f12aec0f097e8008a5262 630934 fonts-georgewilliams_20031023-1_all.deb
 f8f7cfa3b89d72d897745d8c3564229469e46c67 5014 ttf-georgewilliams_20031023-1_all.deb
Checksums-Sha256: 
 5113ea74c8816e09ab352d1455432d637cfcc9e124c5d41b7cbb503f249093c1 2200 fonts-georgewilliams_20031023-1.dsc
 d6292caf53c53588d626a34bbc4c2cdd94dc8207cd0a1ce67891177cfed2a9f3 2849104 fonts-georgewilliams_20031023.orig.tar.xz
 32019fa6f9425a40abf3df1ee80d185b61fdf40a9fa9b541b12c2b84097167d2 4996 fonts-georgewilliams_20031023-1.debian.tar.xz
 1f47aa6e1aee6d54f07232ea80bcf1dfe823edaaae7123498d246d58a450ebf6 630934 fonts-georgewilliams_20031023-1_all.deb
 7bfd03e84d46b2f39f84eb368d0b0e36aa1586563aadd4804bccb324d36691f4 5014 ttf-georgewilliams_20031023-1_all.deb
Files: 
 8063f2debee62c2601ddd2116ee07cd3 630934 fonts optional fonts-georgewilliams_20031023-1_all.deb
 cca46f2748f10faa030cbc5119b33eb3 5014 oldlibs extra ttf-georgewilliams_20031023-1_all.deb
 e7ba39d88c0e3f5a444c0b344b0c31df 2200 fonts optional fonts-georgewilliams_20031023-1.dsc
 2742efffd0b0b2d46ead1e2baeb83d58 2849104 fonts optional fonts-georgewilliams_20031023.orig.tar.xz
 e1c557e631086b351bc15e280492339c 4996 fonts optional fonts-georgewilliams_20031023-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBU3cOLIcvcCxNbiWoAQJ+hQ//aDURyQPX38+2a5Lux2NO+C+kHztAFkr/
PGBUFGT9EPPaUL+fmtM5Q/pZFOOs79MwoIastJoGLwAUxRQhWTccnCoYw1MuY1kJ
VBcMjmjy/lPSmXAX4q156Ze36rjxNlCdlagnjU4YmmBPqn9Fp3kQ7sprr4NllWwl
Fhz0I0iCd4k7ZwgHN/PCn6ZDDpUKVhLG2AbxPjfwMflqtp+I5ZUFmlYHuSIijvvr
48AaqlkdoxzplYllq4n4j3PbBvuHh62VwlWljJBdD2A331y07xiTTGvLB7sbCT93
yGxbqx6vInru02BYcxNSRgGU88bTqdU5X3+lvigPbuzUE8qB5ooDMILpxL5E4eyT
fkjFP/sppi+ISq1VDym08VfsMgMQUkMBymlUsbhWNHzBurZhU+dqmZZC9xwI/VNI
fWg/Yt7X61xq40K3+yR4Lqr3PfEarcPXg68Qusm6KTfKmgYSMO1TfbTerK4ZdH1c
4tyV5A3dDNa06pcFvmdGJqI95HTgyJHMf5aY/9Si8uPI2+mapqQoyWvXnV3gM5IL
TlARRr9bsH9nAZ/LwXc1PxeisTn/rVv+fb5vHVthZPyHXC6+qnFfzzAjouyhp6w5
nkc0whfwFjjceXnxj3EsrPMxWNLO4W/sDBxlxySZ2o/QOJMHHlAXLoAtA2GRt226
OWFpTCQOpKc=
=ZnxX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: