[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659605: marked as done (fonts-tomsontalks: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 15:22:15 +0000
with message-id <E1W9cOd-0001XJ-PT@franck.debian.org>
and subject line Bug#659605: fixed in fonts-tomsontalks 1.1-4
has caused the Debian Bug report #659605,
regarding fonts-tomsontalks: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659605: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659605
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-tomsontalks
Version: 1.1-3
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-f500.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-tomsontalks-1.1/debian/control fonts-tomsontalks-1.1/debian/control
--- fonts-tomsontalks-1.1/debian/control	2011-10-30 14:42:36.000000000 +0000
+++ fonts-tomsontalks-1.1/debian/control	2012-02-12 14:12:10.000000000 +0000
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Gürkan Sengün <gurkan@phys.ethz.ch>
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8.1.0~)
 Standards-Version: 3.9.2
 Homepage: http://frabru.de/c.php/resource/font/TomsonTalks/
 Vcs-svn: svn://svn.debian.org/svn/pkg-fonts/packages/fonts-tomsontalks
@@ -11,6 +12,7 @@
 
 Package: fonts-tomsontalks
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-tomsontalks (<< 1.1-3)
 Provides: ttf-tomsontalks
diff -Nru fonts-tomsontalks-1.1/debian/maintscript fonts-tomsontalks-1.1/debian/maintscript
--- fonts-tomsontalks-1.1/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-tomsontalks-1.1/debian/maintscript	2012-02-12 14:11:45.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-tomsontalks.hints 1.0-2
diff -Nru fonts-tomsontalks-1.1/debian/postinst fonts-tomsontalks-1.1/debian/postinst
--- fonts-tomsontalks-1.1/debian/postinst	2011-10-30 14:29:22.000000000 +0000
+++ fonts-tomsontalks-1.1/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-tomsontalks.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-tomsontalks-1.1/debian/postrm fonts-tomsontalks-1.1/debian/postrm
--- fonts-tomsontalks-1.1/debian/postrm	2011-10-30 14:29:22.000000000 +0000
+++ fonts-tomsontalks-1.1/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-tomsontalks.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-tomsontalks-1.1/debian/preinst fonts-tomsontalks-1.1/debian/preinst
--- fonts-tomsontalks-1.1/debian/preinst	2011-10-30 14:29:22.000000000 +0000
+++ fonts-tomsontalks-1.1/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-tomsontalks.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-tomsontalks
Source-Version: 1.1-4

We believe that the bug you reported is fixed in the latest version of
fonts-tomsontalks, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659605@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-tomsontalks package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 23:43:30 +0900
Source: fonts-tomsontalks
Binary: fonts-tomsontalks ttf-tomsontalks
Architecture: source all
Version: 1.1-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-tomsontalks - comic lettering font
 ttf-tomsontalks - transitional dummy package
Closes: 659605
Changes: 
 fonts-tomsontalks (1.1-4) unstable; urgency=medium
 .
   * Team upload.
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659605)
   * debian/control
     - set "Standards-Version: 3.9.5"
     - set "Build-Depedns: debhelper (>= 9)"
     - move Vcs-svn to Vcs-git
     - set "Priority: extra" for transitional package
     - add "Multi-Arch: foreign"
   * debian/compat
     - set 9
   * debian/rules
     - compress package with xz -z9e
Checksums-Sha1: 
 758e2301ae97cee9914f6ff78a7943b9cd487427 2060 fonts-tomsontalks_1.1-4.dsc
 5f57787d277cc2d3ebf7139410915e5bad74cccf 3892 fonts-tomsontalks_1.1-4.debian.tar.xz
 7d2e3afa40e18b404b5e64c76fa85576d76411b2 38760 fonts-tomsontalks_1.1-4_all.deb
 db9002d4071c94ef4224fa4c1810a52c4f14449c 4192 ttf-tomsontalks_1.1-4_all.deb
Checksums-Sha256: 
 dfcf19e0bf24a0d7a541b740b4f17599113a400c11d50941baf4a29b126f663c 2060 fonts-tomsontalks_1.1-4.dsc
 05d2ba2be07a201f975cbc9aa6c552b3c69d46b2b6d96da9d2f7c4986367c2bc 3892 fonts-tomsontalks_1.1-4.debian.tar.xz
 7bf27474ef1574974ed41e8186480abf302ae60c460da3faadbecd573b44d27b 38760 fonts-tomsontalks_1.1-4_all.deb
 4ec9769302975c9cb11af10b90296188561f5b70bbae720f7e832c47d6edaa4c 4192 ttf-tomsontalks_1.1-4_all.deb
Files: 
 7110836c9f4a497571ed135914affd22 2060 fonts optional fonts-tomsontalks_1.1-4.dsc
 aeb62be25283d9cfd5d3f38b110077d2 3892 fonts optional fonts-tomsontalks_1.1-4.debian.tar.xz
 33e292eccb9695ed4c58c7361eb06428 38760 fonts optional fonts-tomsontalks_1.1-4_all.deb
 577b147f98d11157307df4300b0e8bf8 4192 oldlibs extra ttf-tomsontalks_1.1-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7Qw1AAoJEF0yjQgqqrFAMFQP/2AlSCO/kwgAZj8iS8ydnffL
XmebjNIhwt0nEJ3GNWDeWPYbRNyQn8WTDHwWjppGV0BO3kvRCNciB1uVdOD+6HVx
AqTviK9dNIezBi35wfQI+21UofT5rsz7ilon7u1T1Uixj9ywbcyTcoU91GvQ0EI2
upYfKj7QNWNO/wGPmeaCeHHbhDb/l77M7P3EHZSL0uAHKGNV3LZTwJhQ5RosppEp
NwcWrmFW/A5I3Hb+C01XXzbWzOlvbsFz4t6jQJVcrncL/Yt10wzptqlwJblZxX+6
L7UyqSwDF4REHSQYkSXs7QZVdwupLKaGrYxmEBiyd7rFMbqcNTbtFcUyecmPdc92
i3LELL6xU1abwbGJCWxWQwS20GDQtItd7FrDzXW1LIL/LtNljj3iHm55Z/rNOZ0U
zmFnWRsOxuVzHfCgT4YQGCoo9XOAJZ0U8Dy8kqVBEBia9pC/OyLIDTyvzFmU3uCJ
TyTCJrSZ6Ltpf0YAA0r9QjmIRE1QWCMJmTnQvbAtN/iPcUArD9iPG61Q91V/JpQe
JfgAv95rvf4T60geCqRWUffz2ms0dMh756TW4ROej16qtnCK0PQRt+jo8GZEerpe
XI2AeHOfYrFARZoBbkMzqBzRYGpy0y2sOOxt0dPWoyseQ/ETjQYkrjhukheX7J1+
hJNq5qjMYbDYgioYgIgo
=yGhX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: