[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659594: marked as done (fonts-manchufont: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 13:18:19 +0000
with message-id <E1W9aSh-0001qZ-Ul@franck.debian.org>
and subject line Bug#659594: fixed in fonts-manchufont 2.007.svn0068-4
has caused the Debian Bug report #659594,
regarding fonts-manchufont: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659594: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659594
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-manchufont
Version: 2.007.svn0068-2
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
fonts-manchufont.  This seems generally undesirable; it would be better
to enforce a single code path.  (This is academic for Debian because the
version of dpkg in squeeze supported dpkg-maintscript-helper, hence
Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient
version of dpkg for that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-manchufont-2.007.svn0068/debian/control fonts-manchufont-2.007.svn0068/debian/control
--- fonts-manchufont-2.007.svn0068/debian/control	2011-09-03 10:09:34.000000000 +0100
+++ fonts-manchufont-2.007.svn0068/debian/control	2012-02-12 13:29:38.000000000 +0000
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Arne Goetje <arne@linux.org.tw>
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8.1.0~)
 Standards-Version: 3.9.2
 Homepage: http://sourceforge.net/projects/manchufont/
 Vcs-svn: svn://svn.debian.org/svn/pkg-fonts/packages/fonts-manchufont
@@ -11,6 +11,7 @@
 
 Package: fonts-manchufont
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-manchufont (<< 2.007.svn0068-2)
 Conflicts: ttf-manchufont (<< 2.007.svn0068-2)
diff -Nru fonts-manchufont-2.007.svn0068/debian/maintscript fonts-manchufont-2.007.svn0068/debian/maintscript
--- fonts-manchufont-2.007.svn0068/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-manchufont-2.007.svn0068/debian/maintscript	2012-02-12 13:28:51.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-manchufont.hints 2.007.svn0068-2
diff -Nru fonts-manchufont-2.007.svn0068/debian/postinst fonts-manchufont-2.007.svn0068/debian/postinst
--- fonts-manchufont-2.007.svn0068/debian/postinst	2011-09-01 19:01:40.000000000 +0100
+++ fonts-manchufont-2.007.svn0068/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-manchufont.hints 2.007.svn0068-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-manchufont-2.007.svn0068/debian/postrm fonts-manchufont-2.007.svn0068/debian/postrm
--- fonts-manchufont-2.007.svn0068/debian/postrm	2011-09-01 19:01:40.000000000 +0100
+++ fonts-manchufont-2.007.svn0068/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-manchufont.hints 2.007.svn0068-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-manchufont-2.007.svn0068/debian/preinst fonts-manchufont-2.007.svn0068/debian/preinst
--- fonts-manchufont-2.007.svn0068/debian/preinst	2011-09-01 19:01:40.000000000 +0100
+++ fonts-manchufont-2.007.svn0068/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-manchufont.hints 2.007.svn0068-2 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-manchufont
Source-Version: 2.007.svn0068-4

We believe that the bug you reported is fixed in the latest version of
fonts-manchufont, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659594@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-manchufont package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 22:08:15 +0900
Source: fonts-manchufont
Binary: fonts-manchufont
Architecture: source all
Version: 2.007.svn0068-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-manchufont - Smart OpenType font for Manchu script
Closes: 659594
Changes: 
 fonts-manchufont (2.007.svn0068-4) unstable; urgency=medium
 .
   * Team upload.
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659594)
   * remove unnecessary debian/gbp.conf
Checksums-Sha1: 
 1024bf4be095d28f7269f580ca54b66fe9328e3d 2059 fonts-manchufont_2.007.svn0068-4.dsc
 b64a9417229b26ae31251d7d636a17c4ff6c6a7f 6264 fonts-manchufont_2.007.svn0068-4.debian.tar.xz
 7de678380c3d23c6dca35ae4efd600a1b4bcc0f4 1136314 fonts-manchufont_2.007.svn0068-4_all.deb
Checksums-Sha256: 
 b3c91d70bc5a51ee5250eff59c5319fd0bb53e1b49e6f07ad23a78697a038d50 2059 fonts-manchufont_2.007.svn0068-4.dsc
 b9486af5141d1097135d986a9ed18caeb86367157158666a2af3da3296919c74 6264 fonts-manchufont_2.007.svn0068-4.debian.tar.xz
 6a4ceca5b169fd281e8edd498dcfb7e5c0f6eb89b4f78ae6b884cadc6f5a379e 1136314 fonts-manchufont_2.007.svn0068-4_all.deb
Files: 
 10869808cb3cff70441e69418d530819 2059 fonts optional fonts-manchufont_2.007.svn0068-4.dsc
 8bfbccb2a5e2088a09964b7e792d6ab7 6264 fonts optional fonts-manchufont_2.007.svn0068-4.debian.tar.xz
 5287deb9431ee7525583f3dfdf6a7758 1136314 fonts optional fonts-manchufont_2.007.svn0068-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7PNgAAoJEF0yjQgqqrFAb2AP/1QIaIuSxdSokr+ikrYslzwo
KM+NIN5V1QLPiEg65F12+re/p0k7CKg1sRh3byebQydoEmaMsign9VxpNYruhzT+
kQGuix2gebqQj8YM+0dwpLhF9lZxE847erOkAovsw/aqCYRbCLpULYwzTzfQtz90
H7niS4dkXB4BLKuw7KMGHEzYmK/cTKbZPzGeCJUvoZeH7Xc9PuaNCrL3uI5LfzFL
HgTL9Z/KY4uHf5A/f1Zu3GMsWdNNWfraChqO53fMVg/luXB83Tafp3TL2dbPDc14
S5DCcTtlak/BhsEi4x7ZOe0N6mDVnLyTczDnOScaH5xw8DLzSUWWHKIdDJ7Z+ORb
6lg72G6JOGK+G1cOePvNT9bdPH6GwZVTB1vd8nBqgTAxPCo9S3s8Z/cgVMONyXxl
1llrzxmNKeoLEz15JKuXb8Z/biujuv7etM2MX+qJ9OJf4fJEn8tL+B/zRxHYY2OG
t+/HHBLYn74xoWijHWaf7zbsaEZ0qUPYsJv/89g+hJxCv/FUSvYENhiPNmB+3VMM
bCcvHndbaBZ4JDM0o8F8ZeZcznXTLAfUBogFWxVPOmop5BZNWsALfQylNBjtA2ke
OYp/A8bnGv6odBv0dSADB8wYCutkyL+bErWBbihJay/lGLXHeeTs19lYh2au3iyh
/vFmos0DriLQjLgOGLZM
=2p/7
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: