[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659553: marked as done (fonts-f500: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 12:03:20 +0000
with message-id <E1W9ZI8-0004OH-QK@franck.debian.org>
and subject line Bug#659553: fixed in fonts-f500 1.0-5
has caused the Debian Bug report #659553,
regarding fonts-f500: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659553: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659553
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-f500
Version: 1.0-3
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-f500.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-f500-1.0/debian/control fonts-f500-1.0/debian/control
--- fonts-f500-1.0/debian/control	2011-10-13 13:56:15.000000000 +0100
+++ fonts-f500-1.0/debian/control	2012-02-12 00:51:13.000000000 +0000
@@ -3,11 +3,12 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Gürkan Sengün <gurkan@phys.ethz.ch>
-Build-Depends-Indep: debhelper (>= 8)
+Build-Depends-Indep: debhelper (>= 8.1.0~)
 Standards-Version: 3.9.2
 
 Package: fonts-f500
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-f500 (<< 1.0-2)
 Conflicts: ttf-f500 (<< 1.0-2)
diff -Nru fonts-f500-1.0/debian/maintscript fonts-f500-1.0/debian/maintscript
--- fonts-f500-1.0/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-f500-1.0/debian/maintscript	2012-02-12 00:50:30.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2
diff -Nru fonts-f500-1.0/debian/postinst fonts-f500-1.0/debian/postinst
--- fonts-f500-1.0/debian/postinst	2011-07-21 21:17:25.000000000 +0100
+++ fonts-f500-1.0/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-f500-1.0/debian/postrm fonts-f500-1.0/debian/postrm
--- fonts-f500-1.0/debian/postrm	2011-07-21 21:17:45.000000000 +0100
+++ fonts-f500-1.0/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-f500-1.0/debian/preinst fonts-f500-1.0/debian/preinst
--- fonts-f500-1.0/debian/preinst	2011-07-21 21:17:49.000000000 +0100
+++ fonts-f500-1.0/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-f500
Source-Version: 1.0-5

We believe that the bug you reported is fixed in the latest version of
fonts-f500, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659553@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-f500 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 20:39:42 +0900
Source: fonts-f500
Binary: fonts-f500
Architecture: source all
Version: 1.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-f500 - Wipeout 3 Font
Closes: 659553
Changes: 
 fonts-f500 (1.0-5) unstable; urgency=medium
 .
   * Team upload.
   * debian/control
     - set Standards-Version: 3.9.5
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659553)
Checksums-Sha1: 
 48db7252e7ba7760728ae02a150ae6a2c5437546 1912 fonts-f500_1.0-5.dsc
 be58ffd77717ffe1570d5fb79aa48e565359ec27 1860 fonts-f500_1.0-5.debian.tar.xz
 51d0a51dd0698f7b9f5e79402d56f31912cdee5c 8172 fonts-f500_1.0-5_all.deb
Checksums-Sha256: 
 a6135e1324e5c8d1c8713dcc91f81f2ba0633afcc334a7a005d09eb13ab2175a 1912 fonts-f500_1.0-5.dsc
 423e481ae632bf0eb0423bebc5cd03ae7f64d3b3920a8747315555d14c1600ff 1860 fonts-f500_1.0-5.debian.tar.xz
 38ef23f23cf8c7fa224bea1f31abb484a59eb208156ec6fab0502ba8dd70f6be 8172 fonts-f500_1.0-5_all.deb
Files: 
 8ab92d9bc71df0a2d6887924b041435b 1912 fonts optional fonts-f500_1.0-5.dsc
 09f7780ad4e7c56df7a91ccc2e68aa63 1860 fonts optional fonts-f500_1.0-5.debian.tar.xz
 cb7ee4d0d51f1cef7650f5ba544b0911 8172 fonts optional fonts-f500_1.0-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7N+TAAoJEF0yjQgqqrFApXgP/izUJ65Ha51bhanCKAhZz5qE
llelPBfxyWa0XLK/9+QgPmFfcCuJouo7rbHsAfBxqNCk5+p/vgsTuRp3/5kMtZKO
IvP1hlJaOO3UGxdr7k3qZxF6mxm/ulvQKIdYUcGlprewdz1b3ltErD1oTrSwRWCf
K0LfpuloNffgcM/dye7uEDiabMR7qGYBPMjMfiWD4ygECG9xyDKl/LRq/05IQkRK
1bkgNMX5ozBLhw14WSss3dCG/Zz51fLGdnEJQAQVZwUVr6wXj2WwlX4tcX9/WElf
NLK+rPNZ3IwO6S2/AEldoA636S2tMxi0ZI+cjfpvP67nKN801xlYOXRzj53kHkUJ
Len/G1MxKQneGNnVfCwP/Z+kbgUoqkAGueQ+rl31yfT87UYCon1hv2JiE+trxXa9
STrqc5gO6lgzq5jxoidpIqw6QAwIrskAfo4DYeDcz1AkES8rApOuWh58hjSeTFkG
LhMpffgmBZt7LNJ+vNNcBQMfYcNQFHam5rz99LA7Ougmn/Tp0yfG4Yb21BVJoK7q
xBWaxMXYg0Jq0lmstOGHo02eCLEsEfSPAsLiimX5K9c0ti1VR2qJYSDw2OuMaBrr
h/OCtLFtEpn74E41WFaztFT35nGTnE5aNiHE5vcdsqs4x1cXdQ0C6z8R5OSVJotz
lo1Tw8hmqf29iPoIIJLv
=86NR
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: