[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659551: marked as done (fonts-bpg-georgian: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 11:19:13 +0000
with message-id <E1W9YbR-000283-8q@franck.debian.org>
and subject line Bug#659551: fixed in fonts-bpg-georgian 2012-2
has caused the Debian Bug report #659551,
regarding fonts-bpg-georgian: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659551: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659551
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-bpg-georgian
Version: 0.5a-2
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
fonts-bpg-georgian.  This seems generally undesirable; it would be
better to enforce a single code path.  (This is academic for Debian
because the version of dpkg in squeeze supported
dpkg-maintscript-helper, hence Severity: wishlist; Ubuntu's last LTS
release didn't have a sufficient version of dpkg for that which is why I
care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-bpg-georgian-0.5a/debian/control fonts-bpg-georgian-0.5a/debian/control
--- fonts-bpg-georgian-0.5a/debian/control	2011-07-28 14:54:25.000000000 +0100
+++ fonts-bpg-georgian-0.5a/debian/control	2012-02-12 00:44:23.000000000 +0000
@@ -3,13 +3,14 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Christian Perrier <bubulle@debian.org>
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8.1.0~)
 Standards-Version: 3.9.2
 Vcs-svn: svn://svn.debian.org/svn/pkg-fonts/packages/fonts-bpg-georgian
 Vcs-Browser: http://svn.debian.org/wsvn/pkg-fonts/packages/fonts-bpg-georgian
 
 Package: fonts-bpg-georgian
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Description: BPG Georgian fonts
  This package provides a collection of three Georgian fonts, provided by
diff -Nru fonts-bpg-georgian-0.5a/debian/maintscript fonts-bpg-georgian-0.5a/debian/maintscript
--- fonts-bpg-georgian-0.5a/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-bpg-georgian-0.5a/debian/maintscript	2012-02-12 00:43:51.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-bpg-georgian-fonts.hints 0.5a-1
diff -Nru fonts-bpg-georgian-0.5a/debian/postinst fonts-bpg-georgian-0.5a/debian/postinst
--- fonts-bpg-georgian-0.5a/debian/postinst	2011-07-28 14:19:22.000000000 +0100
+++ fonts-bpg-georgian-0.5a/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-bpg-georgian-fonts.hints 0.5a-1 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-bpg-georgian-0.5a/debian/postrm fonts-bpg-georgian-0.5a/debian/postrm
--- fonts-bpg-georgian-0.5a/debian/postrm	2011-07-28 14:20:12.000000000 +0100
+++ fonts-bpg-georgian-0.5a/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-bpg-georgian-fonts.hints 0.5a-1 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-bpg-georgian-0.5a/debian/preinst fonts-bpg-georgian-0.5a/debian/preinst
--- fonts-bpg-georgian-0.5a/debian/preinst	2011-07-28 14:19:09.000000000 +0100
+++ fonts-bpg-georgian-0.5a/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-bpg-georgian-fonts.hints 0.5a-1 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-bpg-georgian
Source-Version: 2012-2

We believe that the bug you reported is fixed in the latest version of
fonts-bpg-georgian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659551@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-bpg-georgian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 19:53:30 +0900
Source: fonts-bpg-georgian
Binary: fonts-bpg-georgian
Architecture: source all
Version: 2012-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-bpg-georgian - BPG Georgian fonts
Closes: 659551
Changes: 
 fonts-bpg-georgian (2012-2) unstable; urgency=medium
 .
   * Team upload.
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659551)
   * debian/control
     - set "Multi-Arch: foreign"
Checksums-Sha1: 
 e155ac189d5820d9c95e4c3f7a3f1db43788a9f3 2009 fonts-bpg-georgian_2012-2.dsc
 70b963b6056012c76da3294d49be65e5cbd881c1 3144 fonts-bpg-georgian_2012-2.debian.tar.xz
 87d8697718aea0e73f62df8dec273f6f3ada27d5 445272 fonts-bpg-georgian_2012-2_all.deb
Checksums-Sha256: 
 d6eb1eedcc9dc4a6f9d256518276fdba13e4985381090877a06eb7e4ce30f5fe 2009 fonts-bpg-georgian_2012-2.dsc
 cdf305b8e41dd5a51d4e947145b08236ae86929b75d5f650729d7888cda4d97a 3144 fonts-bpg-georgian_2012-2.debian.tar.xz
 db722f70da35ae9fde2b7a7788f00cb30c1c71935bfbcfe05cbfe0198c0ab6e4 445272 fonts-bpg-georgian_2012-2_all.deb
Files: 
 ecb4ebe42767d45d94e52a387f6bc3c0 2009 fonts optional fonts-bpg-georgian_2012-2.dsc
 4e77c111768773b7401fa41a1cb39c5a 3144 fonts optional fonts-bpg-georgian_2012-2.debian.tar.xz
 98d064f43659fee879292a61b5feb0cf 445272 fonts optional fonts-bpg-georgian_2012-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7NQoAAoJEF0yjQgqqrFAlykP/04XEpmGqVP5XIXRHZfau7N6
Uzqzs2UNLUWBESeWJ+8/+g6gsLTVXRY93HJ+V/d+mYqkhj8kIySMoIDe2HNeU9Q9
w3nFmcG6oibfuyNLeaOcQmX2tQqKCkxJod1j+oMHVoRityjZIPdCHLj7ulwLqARW
k3IdGP7jSIYkZs32Cm1ldWT5bWNHO6jeDv7SsvJwzmRdobhXeC3cb/Dh6+koR0NY
Jn5uN/pPBJYCZ+G/XKMQXr0Lq97KUIHFeTaHfLoXTG7HrO3P3gn9Aj5zWoNFhEuA
X2FlDc7I3iTpPKzh033wVTcwYMxCrAXbZW/KEKoaREVgo6YK+j6M1V8ChNeOUfDP
2eC1JgjP8xlibdOEOYpQVhFlOrJLVpqxcZgGzrSwx1cc48xdenWXkstc1Lk47zwN
/nlYL6KlWfC7zpBANKM6L2NhPXra0egZROuw7F5a7fNmR7KXtZNSeqBsfEh66JAj
Eqq771IMIEwklIDhIandiL2X+Dp+kvIyUjj3D57CnjtF72j7mykMnturNgZB6vyV
h4ggVpDf/qhacY+khVoRkVVYxp3RqeMHNcqeU1H+LmFr6AQ3wzssShZCcP0ORIy2
BYcFYT9JUN+4tu9o9gPHJ/8s/Te/95INOz33evOUai1VyFUP1JXUfYIXt/cel2pE
OOe8ALrMR5uYPmOuJE5u
=fcWQ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: