[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659550: marked as done (fonts-beteckna: use dh_installdeb maintscript support)

Your message dated Wed, 29 Jan 2014 22:18:48 +0000
with message-id <E1W8dT6-0004MB-AW@franck.debian.org>
and subject line Bug#659550: fixed in fonts-beteckna 0.4-7
has caused the Debian Bug report #659550,
regarding fonts-beteckna: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659550: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659550
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-beteckna
Version: 0.4-5
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
fonts-beteckna.  This seems generally undesirable; it would be better to
enforce a single code path.  (This is academic for Debian because the
version of dpkg in squeeze supported dpkg-maintscript-helper, hence
Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient
version of dpkg for that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-beteckna-0.4/debian/control fonts-beteckna-0.4/debian/control
--- fonts-beteckna-0.4/debian/control	2011-07-29 15:11:02.000000000 +0100
+++ fonts-beteckna-0.4/debian/control	2012-02-12 00:38:53.000000000 +0000
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Christian Perrier <bubulle@debian.org>,Gürkan Sengün <gurkan@phys.ethz.ch>,Johan Mattsson <johan@beteckna.se>
-Build-Depends: debhelper (>= 8), fontforge-nox | fontforge
+Build-Depends: debhelper (>= 8.1.0~), fontforge-nox | fontforge
 Standards-Version: 3.9.2
 Homepage: http://gnu.ethz.ch/linuks.mine.nu/beteckna/
 Vcs-svn: svn://svn.debian.org/svn/pkg-fonts/packages/fonts-beteckna
@@ -11,6 +11,7 @@
 
 Package: fonts-beteckna
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-beteckna (<< 0.4-4)
 Conflicts: ttf-beteckna (<< 0.4-4)
diff -Nru fonts-beteckna-0.4/debian/maintscript fonts-beteckna-0.4/debian/maintscript
--- fonts-beteckna-0.4/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-beteckna-0.4/debian/maintscript	2012-02-12 00:38:10.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-beteckna.hints 0.4-3
diff -Nru fonts-beteckna-0.4/debian/postinst fonts-beteckna-0.4/debian/postinst
--- fonts-beteckna-0.4/debian/postinst	2011-07-28 17:25:31.000000000 +0100
+++ fonts-beteckna-0.4/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-beteckna.hints 0.4-3 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-beteckna-0.4/debian/postrm fonts-beteckna-0.4/debian/postrm
--- fonts-beteckna-0.4/debian/postrm	2011-07-28 17:25:43.000000000 +0100
+++ fonts-beteckna-0.4/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-beteckna.hints 0.4-3 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-beteckna-0.4/debian/preinst fonts-beteckna-0.4/debian/preinst
--- fonts-beteckna-0.4/debian/preinst	2011-07-28 17:24:30.000000000 +0100
+++ fonts-beteckna-0.4/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-beteckna.hints 0.4-3 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-beteckna
Source-Version: 0.4-7

We believe that the bug you reported is fixed in the latest version of
fonts-beteckna, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659550@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-beteckna package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 30 Jan 2014 06:50:44 +0900
Source: fonts-beteckna
Binary: fonts-beteckna
Architecture: source all
Version: 0.4-7
Distribution: experimental
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-beteckna - geometric Futura-like sans-serif TrueType font
Closes: 659550
Changes: 
 fonts-beteckna (0.4-7) experimental; urgency=medium
 .
   * Team upload.
   * debian/maintscript
     - switch from {pre,post}{inst,rm} scripts. (Closes: #659550)
       Thanks to Colin Watson <cjwatson@ubuntu.com>
   * debian/{pre,post}{inst,rm}
     - remove unnecessary those scripts
   * debian/control
     - Pre-Depedns: s/dpkg (>=1.15.7.2~)/${misc:Pre-Depends}/
     - set Standards-Version: 3.9.5
Checksums-Sha1: 
 4c1c4395792a42d7468ea3c59e25628fad2fd09f 2074 fonts-beteckna_0.4-7.dsc
 d210c41695fdb760d67f07c5b655c8db71ad1881 3444 fonts-beteckna_0.4-7.debian.tar.xz
 652eb1e7f5af954451eb072e4e9fa3f6f72c6f9a 38724 fonts-beteckna_0.4-7_all.deb
Checksums-Sha256: 
 7510246ba53d185d74abce01e8d08e806e98f98525bdf650581d7065341db104 2074 fonts-beteckna_0.4-7.dsc
 60da2a6c19ef26aecd7558a37206117e93e9239e6b028359f28efe47f01357cd 3444 fonts-beteckna_0.4-7.debian.tar.xz
 48cd57e6e272d8d89e6cd3d36402c3e85ffbd28bfebce927c88fae2da1709ad5 38724 fonts-beteckna_0.4-7_all.deb
Files: 
 f84c70d2f39e41bd90dcb257b2ef595d 2074 fonts optional fonts-beteckna_0.4-7.dsc
 477f0831716810dd9c84686e95aa97e4 3444 fonts optional fonts-beteckna_0.4-7.debian.tar.xz
 8947269568391ddf3fb27209829ebf89 38724 fonts optional fonts-beteckna_0.4-7_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS6XpSAAoJEF0yjQgqqrFAPZ4QAKLOSbtOOTT8X0U1odqaD/QK
7waHqIoFxiX5y0G8t0uoyd8Eau4sfc8jn/UuPBvTDczkgKmrSXOVzO5uAUQf+eCr
FL3l8eiwbnaEmpkne/jPupiyXDUL7KrVNfGZRoShqLZ+NNT1BAOXz2eJrBe3bR1d
SxAM+b3+/1p9kjTPHPBRBMhc+BsP1xii+O79NQ54ZXQL2bSqpUjkwmArmcd7XuZ2
wRlHoGBakjQ5RdefsbM659pFnhrw9IBTHflI2Ip99TNh17d5BDDSFMSplJOAopjQ
EReiGzppdgzeSn4vf5xEOCUoKoJtcwYVClwhFWL2HGwSvbl4TexRL0yN9UTEh61p
+d2Sirhy2ZUH+EUDjiEjFDO3mxD2GIGUjO7MBpp0ucX6yovS3bY2DPXAOweUGw8l
/6Tx4m2qGjfImm7EGkwNLjpAHifewvQX/Cl2WlU6mbrOrB9AGnN0rZoaGOz2mdSF
dC5AJpkpGXhVj5yxXiD+cw3t3laFhsct2wRYX1hI4nEG/MualDOewNiJH7C/XNIW
fBBo45zoyE3G0zIkex5Hfb04nauAFsev1DcGKW2GyDix6OM1CWFC/xOAQxIQJddE
KbS4mITPxUGJn7F5LoGnkHOYkSLGcJj7jBtpiVF1j+QUAV3juxaLXzdI0zr1vpF8
w/pgJ+FGG9ItATI5ikts
=/A67
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: