[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659557: marked as done (fonts-junicode: use dh_installdeb maintscript support)

Your message dated Mon, 17 Dec 2012 23:47:28 +0000
with message-id <E1TkkPA-0008Iu-M9@franck.debian.org>
and subject line Bug#659557: fixed in fonts-junicode 0.7.7-1
has caused the Debian Bug report #659557,
regarding fonts-junicode: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659557: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659557
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-junicode
Version: 0.6.17+20110915-1
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
fonts-junicode.  This seems generally undesirable; it would be better to
enforce a single code path.  (This is academic for Debian because the
version of dpkg in squeeze supported dpkg-maintscript-helper, hence
Severity: wishlist; Ubuntu's last LTS release didn't have a sufficient
version of dpkg for that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-junicode-0.6.17+20110915/debian/control fonts-junicode-0.6.17+20110915/debian/control
--- fonts-junicode-0.6.17+20110915/debian/control	2011-10-12 13:25:26.000000000 +0100
+++ fonts-junicode-0.6.17+20110915/debian/control	2012-02-12 01:09:44.000000000 +0000
@@ -3,13 +3,14 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Gürkan Sengün <gurkan@phys.ethz.ch>
-Build-Depends: debhelper (>= 8), fontforge, xgridfit, libxml2-utils, python-libxml2
+Build-Depends: debhelper (>= 8.1.0~), fontforge, xgridfit, libxml2-utils, python-libxml2
 Standards-Version: 3.9.2
 Homepage: http://junicode.sourceforge.net/
 
 Package: fonts-junicode
 Architecture: all
 Recommends: x-ttcidfont-conf | fontconfig
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-junicode (<< 0.6.17+20110525-1)
 Conflicts: ttf-junicode (<< 0.6.17+20110525-1)
diff -Nru fonts-junicode-0.6.17+20110915/debian/maintscript fonts-junicode-0.6.17+20110915/debian/maintscript
--- fonts-junicode-0.6.17+20110915/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-junicode-0.6.17+20110915/debian/maintscript	2012-02-12 01:08:19.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-junicode.hints 0.6.17-1
diff -Nru fonts-junicode-0.6.17+20110915/debian/postinst fonts-junicode-0.6.17+20110915/debian/postinst
--- fonts-junicode-0.6.17+20110915/debian/postinst	2011-05-26 12:03:13.000000000 +0100
+++ fonts-junicode-0.6.17+20110915/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-set -e
-
-CFILE='/etc/defoma/hints/ttf-junicode.hints'
-dpkg-maintscript-helper rm_conffile $CFILE 0.6.17-1 -- "$@"
-
-#DEBHELPER#
diff -Nru fonts-junicode-0.6.17+20110915/debian/postrm fonts-junicode-0.6.17+20110915/debian/postrm
--- fonts-junicode-0.6.17+20110915/debian/postrm	2011-05-26 12:03:08.000000000 +0100
+++ fonts-junicode-0.6.17+20110915/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-set -e
-
-CFILE='/etc/defoma/hints/ttf-junicode.hints'
-dpkg-maintscript-helper rm_conffile $CFILE 0.6.17-1 -- "$@"
-
-#DEBHELPER#
diff -Nru fonts-junicode-0.6.17+20110915/debian/preinst fonts-junicode-0.6.17+20110915/debian/preinst
--- fonts-junicode-0.6.17+20110915/debian/preinst	2011-05-26 12:02:55.000000000 +0100
+++ fonts-junicode-0.6.17+20110915/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,10 +0,0 @@
-#!/bin/sh
-
-set -e
-
-CFILE='/etc/defoma/hints/ttf-junicode.hints'
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile $CFILE 0.6.17-1 -- "$@"
-fi
-
-#DEBHELPER#

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-junicode
Source-Version: 0.7.7-1

We believe that the bug you reported is fixed in the latest version of
fonts-junicode, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659557@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Sengün <gurkan@phys.ethz.ch> (supplier of updated fonts-junicode package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 13 Dec 2012 09:49:23 +0100
Source: fonts-junicode
Binary: fonts-junicode ttf-junicode
Architecture: source all
Version: 0.7.7-1
Distribution: unstable
Urgency: low
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Gürkan Sengün <gurkan@phys.ethz.ch>
Description: 
 fonts-junicode - Unicode font for medievalists (Latin, IPA and Runic)
 ttf-junicode - transitional dummy package
Closes: 659557
Changes: 
 fonts-junicode (0.7.7-1) unstable; urgency=low
 .
   [ Gürkan Sengün ]
   * New upstream release.
 .
   [ Axel Beckert ]
   * Add watch file
   * Apply patch by Colin Watson to use dh_installdeb maintscript support
     instead calling dpkg-maintscript-helper directly from maintainer
     scripts (Closes: #659557)
   * Fix lintian warning conflicts-with-version.
Checksums-Sha1: 
 28c25024b3c8348084e6e6f8a7f6489fa16bdd81 1335 fonts-junicode_0.7.7-1.dsc
 917773dfebec5337f6605958752410bf7c33230c 2068906 fonts-junicode_0.7.7.orig.tar.gz
 31e7f47748e53dfa6812f06c845ceecfdfb39c4b 3903 fonts-junicode_0.7.7-1.debian.tar.gz
 ec21023781cc9de89412681226cf6f70cd76d400 1221346 fonts-junicode_0.7.7-1_all.deb
 a17579d3a085e96cb3b5d731aa2d4751cd192374 5200 ttf-junicode_0.7.7-1_all.deb
Checksums-Sha256: 
 d77972a9a004bb05bb670e97f46502598852210910a8b5081558855c87aaa999 1335 fonts-junicode_0.7.7-1.dsc
 69e28171aaffd03b89f5ce2de699a119899626e1ecc2094ac6b764d20793100b 2068906 fonts-junicode_0.7.7.orig.tar.gz
 8f5e03cd62dc8f4790511b7885901b393494df561ccb05ff3750da743be1295b 3903 fonts-junicode_0.7.7-1.debian.tar.gz
 194505c41c2663bbd70b93ccc5a5eacbf3afc923785860e5c78989f311d5be90 1221346 fonts-junicode_0.7.7-1_all.deb
 8bda35dcea12728961d41ac89a2fd58f590bbd968d16add7ab961a2500c66d54 5200 ttf-junicode_0.7.7-1_all.deb
Files: 
 b32c92d7901f082713583660b9c611da 1335 fonts optional fonts-junicode_0.7.7-1.dsc
 3c5247e78568d948a96cf0d5a074e512 2068906 fonts optional fonts-junicode_0.7.7.orig.tar.gz
 5299d7f5b985d4f07be09c2ca454d9e7 3903 fonts optional fonts-junicode_0.7.7-1.debian.tar.gz
 acb346f062c979d5cdf64100994e6422 1221346 fonts optional fonts-junicode_0.7.7-1_all.deb
 fd2954bb96d8108963922b8673eb65cb 5200 oldlibs extra ttf-junicode_0.7.7-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlDPq+IACgkQwJ4diZWTDt5/DgCbB7iLw2qDClNoM3tAsHjXW39r
9pgAn1kiNWUzwTKVwVD6rkTzZniMTwjq
=W+2/
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: