[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659600: marked as done (fonts-mplus: use dh_installdeb maintscript support)

Your message dated Mon, 17 Dec 2012 23:32:33 +0000
with message-id <E1TkkAj-0005JI-LN@franck.debian.org>
and subject line Bug#659600: fixed in fonts-mplus 053-1
has caused the Debian Bug report #659600,
regarding fonts-mplus: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659600: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659600
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-mplus
Version: 045-1
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-mplus.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-mplus-045/debian/control fonts-mplus-045/debian/control
--- fonts-mplus-045/debian/control	2011-10-07 12:06:52.000000000 +0100
+++ fonts-mplus-045/debian/control	2012-02-12 13:45:04.000000000 +0000
@@ -3,12 +3,13 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Gürkan Sengün <gurkan@phys.ethz.ch>
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8.1.0~)
 Standards-Version: 3.9.2
 Homepage: http://mplus-fonts.sourceforge.jp/
 
 Package: fonts-mplus
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-mplus (<< 042-1)
 Conflicts: ttf-mplus (<< 042-1)
diff -Nru fonts-mplus-045/debian/maintscript fonts-mplus-045/debian/maintscript
--- fonts-mplus-045/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-mplus-045/debian/maintscript	2012-02-12 13:44:17.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-mplus.hints 040-1
diff -Nru fonts-mplus-045/debian/postinst fonts-mplus-045/debian/postinst
--- fonts-mplus-045/debian/postinst	2011-06-14 13:15:10.000000000 +0100
+++ fonts-mplus-045/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-set -e
-
-CFILE='/etc/defoma/hints/ttf-mplus.hints'
-dpkg-maintscript-helper rm_conffile $CFILE 040-1 -- "$@"
-
-#DEBHELPER#
diff -Nru fonts-mplus-045/debian/postrm fonts-mplus-045/debian/postrm
--- fonts-mplus-045/debian/postrm	2011-06-14 13:15:05.000000000 +0100
+++ fonts-mplus-045/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-set -e
-
-CFILE='/etc/defoma/hints/ttf-mplus.hints'
-dpkg-maintscript-helper rm_conffile $CFILE 040-1 -- "$@"
-
-#DEBHELPER#
diff -Nru fonts-mplus-045/debian/preinst fonts-mplus-045/debian/preinst
--- fonts-mplus-045/debian/preinst	2011-06-14 13:14:58.000000000 +0100
+++ fonts-mplus-045/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,10 +0,0 @@
-#!/bin/sh
-
-set -e 
-
-CFILE='/etc/defoma/hints/ttf-mplus.hints'
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile $CFILE 040-1 -- "$@"
-fi
-
-#DEBHELPER#

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-mplus
Source-Version: 053-1

We believe that the bug you reported is fixed in the latest version of
fonts-mplus, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659600@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Sengün <gurkan@phys.ethz.ch> (supplier of updated fonts-mplus package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 11 Dec 2012 09:32:28 +0100
Source: fonts-mplus
Binary: fonts-mplus ttf-mplus
Architecture: source all
Version: 053-1
Distribution: unstable
Urgency: low
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Gürkan Sengün <gurkan@phys.ethz.ch>
Description: 
 fonts-mplus - M+ sans serif fonts with different weights
 ttf-mplus  - transitional dummy package
Closes: 659600 680152
Changes: 
 fonts-mplus (053-1) unstable; urgency=low
 .
   [ Gürkan Sengün ]
   * New upstream version.
 .
   [ Axel Beckert ]
   * Fix watch file to also properly download xz-compressed upstream
     archives. Thanks to Ryo Igarashi for the bug report and
     patch. (Closes: #680152)
   * Use dh_installdeb maintscript support instead of calling
     dpkg-maintscript-helper directly in the maintainer scripts. Thanks
     Colin Watson. (Closes: #659600)
   * Replacing "Conflicts" with "Breaks". Fixes lintian warning
     conflicts-with-version.
Checksums-Sha1: 
 2ae462403e6f40b6002615da59ae10e451cdee1c 1207 fonts-mplus_053-1.dsc
 e5a26a28cbd7dcdf434a336e84a2f89e1be717cc 8502308 fonts-mplus_053.orig.tar.xz
 86355448a02b14f2c1d053c9f96e5966e08efa4c 3044 fonts-mplus_053-1.debian.tar.xz
 a79cc0bce6102deb26f7690bcf83b3b6f67f3788 8505704 fonts-mplus_053-1_all.deb
 64f5802f4b6d3d8c99eae7d1634229bce34724c7 2882 ttf-mplus_053-1_all.deb
Checksums-Sha256: 
 e2fd8edee037a1fc7e04bf8a3f7d32ba29301e528fe6cb2d4103d522caa676fe 1207 fonts-mplus_053-1.dsc
 9142cb0e3384d18178d5761cd43e5ffa04822cf73d28b0099a4850c087e76768 8502308 fonts-mplus_053.orig.tar.xz
 99bb22fcd2f3bee5672006e52dcfe1634464fac48a24c08172b3850b03a181c4 3044 fonts-mplus_053-1.debian.tar.xz
 444245d221d007eeb0586b3e29df6dbabe24e7a0d5246e8ef310eef46283ca8d 8505704 fonts-mplus_053-1_all.deb
 7e20850579ddf0c6c2e91a46762dc6069fc3eeb13d201ff4c850e2d9d2e889db 2882 ttf-mplus_053-1_all.deb
Files: 
 f6f5542dce5dece5334963df8f638d3f 1207 fonts optional fonts-mplus_053-1.dsc
 5d29e9c572e934475f2de9a40dd013d6 8502308 fonts optional fonts-mplus_053.orig.tar.xz
 353a294b536a628541589a531073d427 3044 fonts optional fonts-mplus_053-1.debian.tar.xz
 cfaaebf7c226a6cf75b3a24bf60ad368 8505704 fonts optional fonts-mplus_053-1_all.deb
 55ad1e8013cb9511c73985764bde33e8 2882 oldlibs extra ttf-mplus_053-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlDPpl0ACgkQwJ4diZWTDt4SaQCfadbP025nWUoxu+aZmzuyVqWP
af8An1F8Q8CR/AEmWXLY2UtBcS1lY97y
=D1sl
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: