On 11:02 Tue 27 Nov , Fabian Greffrath wrote:
> Am 27.11.2012 08:44, schrieb Fabian Greffrath:
> >I'd like to rename the create-orig-source script (and all references
> >to it) to get-orig-source to match the corresponding rule in
> >debian/rules. Apart from this, I really think the package is ready for
> >upload! \o/
>
> One last thing: I am not sure about the invokation of the script in
> the get-orig-source rule. Why all the macro fuzz instead of just
> plain "debian/"? And furthermore, I think the script should get
> invoked explicitely with "sh", as its executable bit is unlikely to
> survive the Debian source package creation process.
>
Reason is simple if user executes the get-orig-source target like this
fonts-android/debian/rules get-orig-source
Simply adding debian/create-orig-source will lead to an error this
problem was previously mentioned by Jakub Wilk in review of my package
suckless-tools. So the macro expansion will always make the makefile to
take right path to create-orig-source.
The executable bit survives packaging because it does have a hash
bang. I just checked the resulting debian.tar.gz for permissions. Also
cross checked with suckless-tools package source from experimental
archive.
So do you think its time to ask for a upload? Only I guess for time
being I need to change distribution to experimental till freeze is
over. What do you think?
Regards
--
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
Attachment:
signature.asc
Description: Digital signature