On 12:04 Thu 22 Nov , Fabian Greffrath wrote:
> Hi Vasudev,
>
> Am 21.11.2012 18:45, schrieb Vasudev Kamath:
> >Note that package is not at all finalized nor fine tuned I just pushed
> >so that you can have a look at it.
>
> I have just had a look at the packaging and fixed all the (minor!)
> issues that I found. I did not test your create-orig-source script,
> though it looks reasonable to me, despite some small remarks:
Thanks for fixing the issues. I did few more fixes and the package is
now lintian clean. Have a look at it once and let me know if anything
more needs to be fixed.
>
> - You strip the *.xml and *.mk files from the checkout. I think they
> are pretty harmless and don't eat up much space and bandwidth. Maybe
> there is something we can learn from them, so I would keep them in
> for the next package update.
I will update the package and create-orig-source script in next release
to include those files. I removed them because fonts-droid didn't have
them and README.Debian had mentioned about removing them.
>
> - You do not remove the executable bit from the *.ttf files. Is this
> not an issue anymore?
Ah while fixing the script I guess I accidentally removed the line
removing the executable permission
>
> Thanks a lot for your work!
>
Thanks :-)
--
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
Attachment:
signature.asc
Description: Digital signature