[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#590844: A fix

On Thu, Jul 29, 2010 at 09:23:59PM +0300, Kęstutis Bilūnas wrote:

> Thank you for this report and the patch, but it seems that the upstream
> have already corrected tis bug in the version 20100501. This was done a
> little differently (see
> http://fontforge.cvs.sourceforge.net/viewvc/fontforge/fontforge/gutils/),
> but I checked and it works well with the relative path in command line
> argument.

Thanks for your checking. However, the upstream savestrcpy(), is not actually
safe when dest > src. We are just lucky that that's not the case. But who
knows if it would be in the future. (I don't know why it's also used in
GFileBuildName(), but that may imply other existing use cases.) For me, I'd
prefer memmove() implementation instead.

> So, this bug will be closed on the next upload of the new version of the
> package.

OK. Thanks. I'd say I found this bug while trying to roll a tarball for
my new font release, and it fails 'make distcheck'. I'll just use my patched
version for the release. Luckily, this bug should not cause FTBFS when
building its deb package.

Theppitak Karoonboonyanan

Reply to: