[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] RFS: ttf-rufscript



Dear Andrew,

> I've joined the pkg-fonts project and committed the packaging for
> ttf-rufscript. For some reason it took awhile to get my ssh
> authorization working, but it's up and running now. Please review...

I had a short look over the files that you have uploaded into the pkg-fonts SVN recently (thank you very much!) and would like to suggest the following changes:

debian/control:
- There is no need to depend on a version of cdbs that isn't even in oldstable anymore. - Maybe you should drop the indefinite article "a" from the short descripton. - Is the font created "only using" FOSS tools or "using only" FOSS tools? ;)

debian/watch:
- The first line is really unnecessary (but this is very minor).

debian/ttf-rufscript.deforma-hints:
- This file still points to "/path/to/Rufscript010.ttf"!

debian/README.Debian:
- This may be renamed to README.source, because it simply describes how to generate the source tarball. BTW, the package would fully comply to Policy 3.8.0 then (I believe).
- Please break lines after 80 characters.

My personal opnion is, that it is "cleaner" to package the sourceforge source file (sfd) into the orig.tar.gz and create the ttf at build-time. However, this can wait until upstream has created a "proper" source tarball.

Thanks again and happy hacking!

Cheers,
Fabian


--
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath@leat.ruhr-uni-bochum.de



Reply to: