[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#506229: dpkg-cross fails to provide correct .pc for libpthread-stubs0-dev



Package: dpkg-cross
tag 506229 + pending
thanks

On Thu, 20 Nov 2008 08:59:52 +0100
Marco Amadori <amadorim@vdavda.com> wrote:

> On Wednesday 19 November 2008, 19:31:31, you wrote:
> 
> > the pkgconfig file is in /usr/share/ instead of the
> > more usual /usr/lib/
> 
> I thought it used a different pattern matching, but this makes
> perfect sense.
> 
> It could be a bug of libpthread-stubs0-dev ?

No, pkgconfig should support files in /usr/share/pkgconfig/ and so
should dpkg-cross.

The issue is that the pkgconfig files in /usr/share/ never seem to
contain any useful data, yet packages still look for just the file.
None of the pkgconfig files in my /usr/share/pkgconfig/ contain any
data for --cflags or --libs

neil@dwarf:~$ pkg-config --cflags pthread-stubs
 
neil@dwarf:~$ pkg-config --libs pthread-stubs
 
I'm not sure why pthread-stubs-dev contains a pkgconfig file that
provides no pkgconfig data but that is common to all the pkgconfig
files in /usr/share/pkgconfig/ so it's reasonable for dpkg-cross to
handle them (to prevent build errors against the -dev package
using /usr/share/pkgconfig/), even if nothing useful is actually inside
the files.

diff -p -u -b -B -r1.64 dpkg-cross
--- dpkg-cross	14 Oct 2008 20:49:48 -0000	1.64
+++ dpkg-cross	21 Nov 2008 09:39:18 -0000
@@ -831,6 +831,9 @@ sub sub_build {
 			# regular .pc file in /usr/lib/pkgconfig
 			fix_pc_file("$src$_", "$dst$crosslib/$1") or goto fail;
 			# not for lib64: I don't know if there is any rationale
+		} elsif (m:/usr/share/(pkgconfig/[^/]+.pc)$:) {
+			# regular .pc file in /usr/share/pkgconfig
+			fix_pc_file("$src$_", "$dst$crossdir/share/$1") or goto fail;
 		} elsif (m:^/usr/(src/.*):) {
 			# any files under /usr/src/
 			link_file("$src$_", "$dst$crossdir/$1") or goto fail;


neil@dwarf:test$ dpkg -c libpthread-stubs0-dev_0.1-2_arm.deb | grep stubs.pc
-rw-r--r-- root/root       169 2007-06-27 04:35 ./usr/share/pkgconfig/pthread-stubs.pc
neil@dwarf:test$ dpkg -c libpthread-stubs0-dev-arm-cross_0.1-2_all.deb | grep stubs.pc
-rw-r--r-- root/root       183 2008-11-21 09:35 ./usr/arm-linux-gnu/share/pkgconfig/pthread-stubs.pc

That change will be in dpkg-cross 2.3.4:

http://alioth.debian.org/plugins/scmcvs/cvsweb.php/dpkg-cross/dpkg-cross.diff?r1=1.64;r2=1.65;cvsroot=dpkg-cross;f=h

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.linux.codehelp.co.uk/
http://e-mail.is-not-s.ms/

Attachment: pgp4SpGjy0eoA.pgp
Description: PGP signature


Reply to: