Bug#1104178: elpa-doom-themes: upgrade fails: cannot overwrite non-directory ... with directory

[David Bremner <david@tethera.net>]

Xiyue Deng <manphiz@gmail.com> writes:

>>
>> Is it sufficient to check the top level? what if there is deeper nested
>> directories? Apologies if I missed some context.
>>
>
> Before 2.1.1, the install script only creates symlinks for everything on
> the top level (see code for release 2.1.1[1]).  Therefore I think
> handling top level should be sufficient.
>

OK. Then 'find "${elcdir}" -maxdepth 1 -type l -delete'
seems simpler / safer then the script, but if you and Sean
are happier with the script (fragment), then that's fine.

> I think what you said is true, though that's more like the work of the
> remove script, which basically does this already.  Wiping everything
> on every install/upgrade sounds like an overkill to me.  On the other
> hand, it doesn't affect correctness, and should still be fast enough
> as everything is basically a symlink.  I don't have a strong
> preference.

I guess it's unlikely, but conceivably some package installed into
../elpa in some custom way that involves deeper symlinks. Probably
that's not a case we need to worry about, and generally the fewer "rm -rf
${foo}" we have in maintainer script the better.