[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1069017: marked as done (rtags: FTBFS due to time64_t changes)

Your message dated Fri, 19 Apr 2024 22:36:59 +0000
with message-id <E1rxwqp-008fJl-PB@fasolo.debian.org>
and subject line Bug#1069017: fixed in rtags 2.38-10
has caused the Debian Bug report #1069017,
regarding rtags: FTBFS due to time64_t changes
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1069017: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069017
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: rtags
Version: 2.38-9
Severity: serious
Tags: patch

Hello maintainer, I fixed a FTBFS on armhf due to time64_t. The regex was causing "=64" to be stripped from _FILE_OFFSET_BITS, causing cmake to fail to build test code.

With this regex the example test code of clang fails in cmake, causing an error.
this is due to -I/usr/lib/llvm-18/include -std=c++17 -fno-exceptions -funwind-tables -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
becoming:
-I/usr/lib/llvm-18/include;-D_GNU_SOURCE;-D_FILE_OFFSET_BITS;-D_LARGEFILE_SOURCE;-D_FILE_OFFSET_BITS;-D__STDC_CONSTANT_MACROS;-D__STDC_FORMAT_MACROS;-D__STDC_LIMIT_MACROS

If you undefine _FILE_OFFSET_BITS and you enable _TIME_BITS=64 you get a FTBFS

/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"


  * Fix regex on find clang without stripping defines content.


Thanks for considering the patch.
diff -Nru rtags-2.38/debian/patches/fix-regex.patch rtags-2.38/debian/patches/fix-regex.patch
--- rtags-2.38/debian/patches/fix-regex.patch	1970-01-01 01:00:00.000000000 +0100
+++ rtags-2.38/debian/patches/fix-regex.patch	2024-04-15 08:50:11.000000000 +0200
@@ -0,0 +1,18 @@
+Description:
+   * Add -D_FILE_OFFSET_BITS=64 to fix FTBFS on armhf
+     (bad regex on find clang making build fail)
+Author: Gianfranco Costamagna <locutusofborg@debian.org>
+Forwarded: https://github.com/Andersbakken/rtags/pull/1439
+Last-Update: 2024-04-15
+
+--- rtags-2.38.orig/cmake/FindLibClang.cmake
++++ rtags-2.38/cmake/FindLibClang.cmake
+@@ -88,7 +88,7 @@ if (NOT LIBCLANG_CXXFLAGS)
+         endif ()
+         set(LIBCLANG_CXXFLAGS "-I${LIBCLANG_CXXFLAGS}")
+     endif ()
+-    string(REGEX MATCHALL "-(D__?[a-zA-Z_]*|I([^\" ]+|\"[^\"]+\"))" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
++    string(REGEX MATCHALL "-(D__?[a-zA-Z_=0-9]*|I([^\" ]+|\"[^\"]+\"))" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
+     string(REGEX REPLACE ";" " " LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
+     set(LIBCLANG_CXXFLAGS ${LIBCLANG_CXXFLAGS} CACHE STRING "The LLVM C++ compiler flags needed to compile LLVM based applications.")
+     unset(LIBCLANG_CXXFLAGS_HACK_CMAKECACHE_DOT_TEXT_BULLSHIT CACHE)
diff -Nru rtags-2.38/debian/patches/series rtags-2.38/debian/patches/series
--- rtags-2.38/debian/patches/series	2023-08-29 19:36:08.000000000 +0200
+++ rtags-2.38/debian/patches/series	2024-04-15 08:49:15.000000000 +0200
@@ -15,3 +15,4 @@
 0015-expand-range-of-llvm-versions.patch
 0016-always-finish-the-connection.patch
 0017-Add-when-argument-to-define-obsolete-function-alias.patch
+fix-regex.patch

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: rtags
Source-Version: 2.38-10
Done: Denis Danilov <danilovdenis@yandex.ru>

We believe that the bug you reported is fixed in the latest version of
rtags, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1069017@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Denis Danilov <danilovdenis@yandex.ru> (supplier of updated rtags package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 19 Apr 2024 23:52:58 +0200
Source: rtags
Architecture: source
Version: 2.38-10
Distribution: unstable
Urgency: medium
Maintainer: Debian Emacsen team <debian-emacsen@lists.debian.org>
Changed-By: Denis Danilov <danilovdenis@yandex.ru>
Closes: 1069017
Changes:
 rtags (2.38-10) unstable; urgency=medium
 .
   * add patch by Gianfranco Costamagna to fix build failure (Closes: #1069017)
   * fix lintian warning
   * update Standards Version to 4.7.0
Checksums-Sha1:
 7969e4241730b1b025d99ec67e70c05ba5ce4b26 2435 rtags_2.38-10.dsc
 60430aaa37652ad7d323391c0cd7ee4876ff607e 14836 rtags_2.38-10.debian.tar.xz
 8ca7482a8c3d3abea3b7bef5540768b125e5218b 10129 rtags_2.38-10_source.buildinfo
Checksums-Sha256:
 5ff7cc1d1b9ff7227f5d63be4af3b0b1d002aa361cc46a8280db2208dc8979ae 2435 rtags_2.38-10.dsc
 815cc2b9b015bebf8985618263c5ab5e3092829993255c77933f2919bb76085c 14836 rtags_2.38-10.debian.tar.xz
 1720836666da170f88a0814b37e743b80c509dc897791511cd0b272a927f18e2 10129 rtags_2.38-10_source.buildinfo
Files:
 7ef1e93735e7ea751002f50075abe10d 2435 devel optional rtags_2.38-10.dsc
 3c3b3f6ce768d5db5a2cc5f19ca3a435 14836 devel optional rtags_2.38-10.debian.tar.xz
 9d40b6312bbbd0dd4c22ad0f768ee9d2 10129 devel optional rtags_2.38-10_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJLBAEBCgA1FiEEshPc31UAujv7Yr/INjbeIV6N62MFAmYi7aMXHGRhbmlsb3Zk
ZW5pc0B5YW5kZXgucnUACgkQNjbeIV6N62N6+g//V8oLfyWlC9NXK6O7RUVtXCXJ
0x6gieVs4f1WvddvJDGjZgFcOEKumV4Ab88+DUmkEvAuNqOzxaCUgLzghzIWxsOk
XRb6dRPcNWZ7ld0d9Y9EaPDlmic7S8fQdCzYOxN67fEDqrgBKbsPCBZwereXUxJr
6ck9yDD+xzEu5PoK1coJnWXCBROSS0/V7U6imqqDIGHdy0F7TFjHYCci+2GHsqY7
YcajPRcOVglkMKaCRHbcknz90VC4eh5igMkUomyuWxpj6Pc9u1H2HYnj0Pidz77t
dAdDj66Nr5EmwrHXLE/SIV7rv+HlwNL5UK7ZDzeErCrvu63X1edluw3Y29Q6vrto
+8dt0JX6SFegoHy+VgzIujcRD8AGLFV1J7u0vnxMWeRoCfrRvHmyV/sNp6cl0nUB
4zwqbldzJigAiREZ1xirwAgjovuMraNmE9C0Ke2/rJxUzX78sUOrA6BE42OwDYxS
7OO8+DN/IdYlazTFjV0mOylIb2EUszXg7cWbizY37JG+FJH0uq5FF1hIICWqNMWK
d88H4hRtI15iG7HmkX4xBL37vOi4Z7ZoKR0k5VE2sHE0sDNR7T4r+9YirJnVqN6W
tGzcPR9ilIFqCv65PYNDRZ011AaMD09EEZTlaAMkBHPNNYrQxMhlWIb22awuPanY
G3IMcVI8aqGsy5ry+pk=
=SvgF
-----END PGP SIGNATURE-----

Attachment: pgp6fW7f5tAwe.pgp
Description: PGP signature


--- End Message ---
Reply to: