Bug#1074305: elpa-dpkg-dev-el: debian-changelog-mode buffers are not fontified in Emacs 30

[Sven Joachim <svenjoac@gmx.de>]

Control: tags -1 + patch

On 2024-06-26 11:54 +0200, Sven Joachim wrote:

> Package: elpa-dpkg-dev-el
> Version: 37.12
> Severity: normal
>
> I have started to use Emacs from the recently created emacs-30 branch,
> and noticed that in debian-changelog-mode buffers font-lock-mode is nil
> (M-x font-lock mode fixes that for the current buffer).  In the Emacs 30
> NEWS file I found the following item:
>
> ,----
> | ** 'define-globalized-minor-mode' requires that modes use 'run-mode-hooks'.
> | Minor modes defined with 'define-globalized-minor-mode', such as
> | 'global-font-lock-mode', will not be enabled any more in those buffers
> | whose major modes fail to use 'run-mode-hooks'.  Major modes defined
> | with 'define-derived-mode' are not affected.  'run-mode-hooks' has been the
> | recommended way to run major mode hooks since Emacs 22.
> `----

The same problem exists in other modes from elpa-dpkg-dev-el.

> The solution looks simple, but I have not tested it yet:
>
> diff --git a/debian-changelog-mode.el b/debian-changelog-mode.el
> index febb60e..43891c0 100644
> --- a/debian-changelog-mode.el
> +++ b/debian-changelog-mode.el
> @@ -1544,7 +1544,7 @@ interface to set it, or simply set the variable
>     (debian-changelog-highlight-mouse-t
>      (debian-changelog-setup-highlight-mouse-keymap)
>      (debian-changelog-highlight-mouse)))
> -  (run-hooks 'debian-changelog-mode-hook))
> +  (run-mode-hooks 'debian-changelog-mode-hook))
>  ;;(easy-menu-add debian-changelog-menu))

Works for me now, and I have created a merge request on Salsa:
https://salsa.debian.org/emacsen-team/dpkg-dev-el/-/merge_requests/3

Cheers,
       Sven