[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

yasnippet commits review



Dear Aymeric,

Following up from our conversation on IRC:

ca55bc8: Nice find, and fix, thank you! (I haven't tested it yet, but
assume you have, that it's good, and that it will pass when I test it)
       
2ff39eb: Nitpick: If you patch fixes the incompatibility, please say so
:)  Also, it may be nice to say that it's related to #1020143 if that's
the case.

8aa6556: Thank you for noting "no changes required" because this item
requires a human to check for compliance :)

7c4ae4a: Oh wow, this looks like something that may may have been out of
date for years.  Thanks!

b9ccd2b: What's the purpose of this digression from the way dh_elpa does
things?  It looks like it introduces potential indeterminacy.  At a
minimum, an explanation needs to be provided.

0a76135: I will not sponsor due to this action, because it's not ok
to disable all 91 tests, when only 7 are failing
  https://ci.debian.net/data/autopkgtest/unstable/amd64/y/yasnippet/28997908/log.gz

Feel skip these seven tests using another method, but please say why
this is the correct action.


Regards,
Nicholas

Attachment: signature.asc
Description: PGP signature


Reply to: