control: tags -1 pending
thanks
Manphiz <manphiz@gmail.com> writes:
> control: tag -1 patch
> thanks
>
> Gianfranco Costamagna <locutusofborg@debian.org> writes:
>
>> Source: flycheck
>> Version: 33~git20230824.e56e30d-1
>> Severity: serious
>> Forwarded: https://github.com/flycheck/flycheck/issues/2036
>>
>> Hello, looks like if we build with gawk installed, a new test fails.
>>
>> I'm filing as serious, because gawk is a tool installed on many systems.
>>
>> I just added the dependency at build time and found the issue on DoM
>> http://debomatic-amd64.debian.net/distribution#unstable/flycheck/33~git20230824.e56e30d-1.1/buildlog
>>
>>
>> Test flycheck-define-checker/awk-gawk/syntax-error backtrace:
>> signal(ert-test-failed (((should (equal (mapcar #'flycheck-error-wit
>> ert-fail(((should (equal (mapcar #'flycheck-error-without-group expe
>> (if (unwind-protect (setq value-229 (apply fn-227 args-228)) (setq f
>> (let (form-description-231) (if (unwind-protect (setq value-229 (app
>> (let ((value-229 'ert-form-evaluation-aborted-230)) (let (form-descr
>> (let* ((fn-227 #'equal) (args-228 (condition-case err (let ((signal-
>> (let ((expected (flycheck-ert-sort-errors (mapcar (apply-partially #
>> flycheck-ert-should-errors((2 nil warning "x=|\n ^ syntax error" :c
>> apply(flycheck-ert-should-errors (2 nil warning "x=|\n ^ syntax err
>> (let ((process-hook-called 0) (suspicious nil)) (add-hook 'flycheck-
>> flycheck-ert-should-syntax-check-in-buffer((2 nil warning "x=|\n ^
>> apply(flycheck-ert-should-syntax-check-in-buffer (2 nil warning "x=|
>> (progn (insert-file-contents file-name 'visit) (set-visited-file-nam
>> (unwind-protect (progn (insert-file-contents file-name 'visit) (set-
>> (progn (unwind-protect (progn (insert-file-contents file-name 'visit
>> (unwind-protect (progn (unwind-protect (progn (insert-file-contents
>> (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
>> (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
>> (let ((file-name (flycheck-ert-resource-filename resource-file))) (i
>> (let ((mode (car tail))) (if (fboundp mode) nil (ert-skip (format "%
>> (while tail (let ((mode (car tail))) (if (fboundp mode) nil (ert-ski
>> (let ((tail modes)) (while tail (let ((mode (car tail))) (if (fbound
>> flycheck-ert-should-syntax-check("language/awk/syntax-error.awk" awk
>> (closure (truncated-stdin-mode-abbrev-table truncated-stdin-mode-syn
>> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>> ert-run-test(#s(ert-test :name flycheck-define-checker/awk-gawk/synt
>> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>> ert-run-tests((and "flycheck-" t) #f(compiled-function (event-type &
>> ert-run-tests-batch((and "flycheck-" t))
>> ert-run-tests-batch-and-exit((and "flycheck-" t))
>> (let ((selector (car-safe (prog1 argv (setq argv (cdr argv)))))) (if
>> flycheck-run-tests-batch-and-exit()
>> (let ((debug-on-error t)) (flycheck-run-tests-batch-and-exit))
>> (let* ((load-prefer-newer t) (source-directory (locate-dominating-fi
>> flycheck-run-tests-main()
>> load-with-code-conversion("/<<BUILDDIR>>/flycheck-33~git202
>> command-line-1(("-l" "package" "--eval" "(add-to-list 'package-direc
>> command-line()
>> normal-top-level()
>> Test flycheck-define-checker/awk-gawk/syntax-error condition:
>> (ert-test-failed
>> ((should
>> (equal
>> (mapcar #'flycheck-error-without-group expected)
>> (mapcar #'flycheck-error-without-group current)))
>> :form
>> (equal
>> (#s(flycheck-error #<killed buffer> awk-gawk "/<<PKGBUILDDIR>>/test/resources/language/awk/syntax-error.awk" 2 nil "x=|\n ^ syntax error" warning nil nil nil nil))
>> nil)
>> :value nil :explanation
>> (different-types
>> (#s(flycheck-error #<killed buffer> awk-gawk "/<<PKGBUILDDIR>>/test/resources/language/awk/syntax-error.awk" 2 nil "x=|\n ^ syntax error" warning nil nil nil nil))
>> nil)))
>> FAILED 110/562 flycheck-define-checker/awk-gawk/syntax-error (0.139626 sec) at test/flycheck-test.el:1
>>
>> We are already skipping a bunch of tests in a patch, so maybe we can add also this one, or wait for upstream
>> to double check what is going wrong.
>>
>> G.
>>
>
> Looks like the best action here is to mark this test as flaky as well.
>
> Unfortunately I don't seem to have permission to push to
> emacsen-team/flycheck yet, so I've prepared a merge request[1] instead.
> Looking for sponsorship :)
>
> [1] https://salsa.debian.org/emacsen-team/flycheck/-/merge_requests/4
Finally got access from David. I have prepared a revision for the fix
and uploaded to mentors[1]. Now looking for sponsors :)
[1] https://mentors.debian.net/package/flycheck/
--
Manphiz
Attachment:
signature.asc
Description: PGP signature