Sean Whitton <spwhitton@spwhitton.name> writes: > control: tag -1 +pending > > Hello, > > On Sat 28 Sep 2019 at 04:50PM -04, Nicholas D Steeves wrote: > >> dh-elpa-test appears to have an undocumented hard dependency on >> (ert-run-test-batch-and-exit), specifically "-and-exit", and this >> one-function expression must appear as the final line of the defined >> ert_helper. > > Per the existing documentation of ert_helper, it would not be correct to > set ert_helper to run code that does some work, and then ends by calling > (ert-run-test-batch-and-exit). That's what ert_eval is for. > In this case it's more: run a second round of tests using a different upstream provided method, and output how long each test took, plus time for garbage collection, and of a course a PASS||FAIL. I believe some of the variables may be set different for this second. Upstream and I are finally hunting for whatever is causing those periodic failures on DebCI (3% failure rate) and his Travis instance (more than 3% failure rate) The script is scripts/elpy-test-benchmark.el I seem to remember that ert_eval didn't provide useful output in case of failure, where running it as an ert_helper did. > I believe you're correct that there is a requirement that the ert_helper > code kill Emacs with a correct exit code in order for dh_elpa_test to > work properly, so I'm adding documentation for that. Thanks! Nicholas
Attachment:
signature.asc
Description: PGP signature