[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#719172: marked as done (emacs-goodies-el: graphviz-dot-mode quote compile-command filename)

Your message dated Tue, 24 Jul 2018 07:51:43 +0800
with message-id <877ell1pf4.fsf@tethera.net>
and subject line looks fixed.
has caused the Debian Bug report #719172,
regarding emacs-goodies-el: graphviz-dot-mode quote compile-command filename
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
719172: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719172
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: emacs-goodies-el
Version: 35.4
Severity: minor
File: /usr/share/emacs/site-lisp/emacs-goodies-el/graphviz-dot-mode.el

In graphviz-dot-mode it'd be good if the compile-command constructed
quoted the buffer filename with shell-quote-argument

      (set (make-local-variable 'compile-command)
       (concat graphviz-dot-dot-program
               " -T" graphviz-dot-preview-extension " "
               (shell-quote-argument buffer-file-name)
               " > "
               (shell-quote-argument (file-name-sans-extension
                                      buffer-file-name))
               "." graphviz-dot-preview-extension)))

This lets it work on filenames with spaces, and guards against arbitrary
shell code if the filename accidentally contains a ";" or similar shell
special char.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages emacs-goodies-el depends on:
ii  bash                     4.2+dfsg-1
ii  dpkg                     1.16.10
ii  emacs21 [emacsen]        21.4a+1-5.7
ii  emacs22-gtk [emacsen]    22.3+1-1.2
ii  emacs23-lucid [emacsen]  23.4+1-4
ic  emacs24 [emacsen]        24.3+1-1
ii  emacs24-lucid [emacsen]  24.3+1-1
ii  install-info             5.1.dfsg.1-4
ii  xemacs21-mule [emacsen]  21.4.22-4

Versions of packages emacs-goodies-el recommends:
ii  dict      1.12.1+dfsg-2
ii  perl-doc  5.14.2-21
ii  wget      1.14-2

emacs-goodies-el suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
The latest version (below) looks like it uses shell-quote-command already. Maybe
you or someone else reported it upstream? Please reopen the bug if there
is more quoting needed.

(defun graphviz-compile-command (f-name)
  (when f-name
    (setq compile-command
          (concat graphviz-dot-dot-program
                  " -T" graphviz-dot-preview-extension " "
                  (shell-quote-argument f-name)
                  " -o "
                  (shell-quote-argument
                   (graphviz-output-file-name f-name))))))

--- End Message ---
Reply to: