[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating use-package, Version and Package-Version mess



Пт 07 дек 2018 @ 18:46 Sean Whitton <spwhitton@spwhitton.name>:

> Thank you for working on this.
>
> On Wed 05 Dec 2018 at 01:14PM +0500, Lev Lamberov wrote:
>
>> Now it became a bit more complicated. So, there's 2.4 release, which
>> contains the following Emacs Lisp files (declared Version included, no
>> Package-Version declaration in the original source code):
>>
>> bind-chord.el, 0.2
>> bind-key.el, 2.4
>> use-package-bind-key.el, 1.0
>> use-package-chords.el, 0.2
>> use-package-core.el, 2.4
>> use-package-delight.el, 1.0
>> use-package-diminish.el, 1.0
>> use-package-ensure-system-package.el, 0.2
>> use-package-ensure.el, 1.0
>> use-package-jump.el, 1.0
>> use-package-lint.el, 1.0
>> use-package.el, 2.4
>>
>> Stable MELPA contains the following (declared Version and
>> Package-Version included):
>>
>> bind-chord.el, 0.2, 2.4
>> bind-key.el, 2.4, 2.4
>>
>> use-package.tar, 2.4 (no Package-Version declaration):
>> use-package-bind-key.el, 1.0
>> use-package-core.el, 2.4
>> use-package-delight.el, 1.0
>> use-package-diminish.el, 1.0
>> use-package-ensure.el, 1.0
>> use-package-jump.el, 1.0
>> use-package-lint.el, 1.0
>> use-package.el, 2.4
>>
>> use-package-chords.el, 0.2, 2.4
>> use-package-ensure-system-package.el, 0.2, 2.4
>>
>> So, sticking to stable MELPA version will not require splitting the
>> source code into several source packages. Should I patch Version (change
>> it everywhere to 2.4) or include Package-Version (as it is done in
>> MELPA)? The main motivation is to choose a plan which will not confuse
>> users running package-list-packages or some alternative (that is,
>> use-package and its related packages should not be marked as outdated or
>> something).
>
> To confirm, are you saying that MELPA has added Package-Version headers,
> overriding the Version: headers from upstream, such that everything in
> 2.4?  What about the libs in your MELPA list that are 1.0?

Yes, at least in stable MELPA. And these are the only differences.
Please, find the diff between the original source and stable MELPA
attached.

Cheers!
Lev

===File /home/dogsleg/tmp/orig_melpa.diff===================
diff -u -r use-package-orig/bind-chord.el use-package-melpa/bind-chord.el
--- use-package-orig/bind-chord.el	2018-11-20 04:50:27.000000000 +0500
+++ use-package-melpa/bind-chord.el	2018-12-08 00:57:04.000000000 +0500
@@ -4,6 +4,7 @@
 
 ;; Author: Justin Talbott <justin@waymondo.com>
 ;; Keywords: convenience, tools, extensions
+;; Package-Version: 2.4
 ;; URL: https://github.com/waymondo/use-package-chords
 ;; Version: 0.2
 ;; Package-Requires: ((bind-key "1.0") (key-chord "0.6"))
diff -u -r use-package-orig/bind-key.el use-package-melpa/bind-key.el
--- use-package-orig/bind-key.el	2018-11-20 04:50:27.000000000 +0500
+++ use-package-melpa/bind-key.el	2018-12-08 00:57:13.000000000 +0500
@@ -7,6 +7,7 @@
 ;; Created: 16 Jun 2012
 ;; Modified: 29 Nov 2017
 ;; Version: 2.4
+;; Package-Version: 2.4
 ;; Keywords: keys keybinding config dotemacs
 ;; URL: https://github.com/jwiegley/use-package
 
diff -u -r use-package-orig/use-package-chords.el use-package-melpa/use-package-chords.el
--- use-package-orig/use-package-chords.el	2018-11-20 04:50:27.000000000 +0500
+++ use-package-melpa/use-package-chords.el	2018-12-08 10:02:18.000000000 +0500
@@ -4,6 +4,7 @@
 
 ;; Author: Justin Talbott <justin@waymondo.com>
 ;; Keywords: convenience, tools, extensions
+;; Package-Version: 2.4
 ;; URL: https://github.com/waymondo/use-package-chords
 ;; Version: 0.2
 ;; Package-Requires: ((use-package "2.1") (bind-key "1.0") (bind-chord "0.2") (key-chord "0.6"))
diff -u -r use-package-orig/use-package-ensure-system-package.el use-package-melpa/use-package-ensure-system-package.el
--- use-package-orig/use-package-ensure-system-package.el	2018-11-20 04:50:27.000000000 +0500
+++ use-package-melpa/use-package-ensure-system-package.el	2018-12-08 10:02:39.000000000 +0500
@@ -4,6 +4,7 @@
 
 ;; Author: Justin Talbott <justin@waymondo.com>
 ;; Keywords: convenience, tools, extensions
+;; Package-Version: 2.4
 ;; URL: https://github.com/waymondo/use-package-ensure-system-package
 ;; Version: 0.2
 ;; Package-Requires: ((use-package "2.1") (system-packages "1.0.4"))
============================================================


Reply to: